Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333991: Issue 3439 - Add a build script for devbuilds (Closed)

Created:
Jan. 19, 2016, 4 p.m. by Felix Dahlke
Modified:
Jan. 20, 2016, 3:23 p.m.
Reviewers:
pavel
CC:
jan
Visibility:
Public.

Description

Issue 3439 - Add a build script for devbuilds

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -10 lines) Patch
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M AdblockPlusSafari.xcodeproj/project.pbxproj View 20 chunks +20 lines, -8 lines 1 comment Download
M AdblockPlusSafari/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M AdblockPlusSafariExtension/Info.plist View 1 chunk +1 line, -1 line 0 comments Download
A build.py View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
Jan. 19, 2016, 4:12 p.m. (2016-01-19 16:12:21 UTC) #1
pavel
Jan. 20, 2016, 3:18 p.m. (2016-01-20 15:18:48 UTC) #2
LGTM

https://codereview.adblockplus.org/29333991/diff/29334014/AdblockPlusSafari.x...
File AdblockPlusSafari.xcodeproj/project.pbxproj (right):

https://codereview.adblockplus.org/29333991/diff/29334014/AdblockPlusSafari.x...
AdblockPlusSafari.xcodeproj/project.pbxproj:1116: CODE_SIGN_RESOURCE_RULES_PATH
= "$(SDKROOT)/ResourceRules.plist";
Yeah. We need this stupid hack as well. I wonder if anyone is even embarrassed
at Apple.

Powered by Google App Engine
This is Rietveld