Issue 3590 - Automate release build generation

Issue 3590 - Automate release build generation

[pavel, 2016-01-27 14:04:01]

https://codereview.adblockplus.org/29334710/diff/29334711/build.py
File build.py (right):

https://codereview.adblockplus.org/29334710/diff/29334711/build.py#newcode50
build.py:50: package_name = "adblockplussafariios-release-%s.ipa" % BUILD_NUMBER
Forewarning: Python noob deducting multiparam printf syntax

This could be shortened to 
"adblockplussafariios-%s-%s.ipa" % build_type % BUILD_NUMBER
You are enforcing those two variants in usage check anyway.

[Felix Dahlke, 2016-01-27 16:29:03]

Turns out I have some more homework to do, unfortunately.

1. I need to use a different code signing identity for release builds - just
forgot that, done now, no rocket science at all.

2. We run into this problem:
http://stackoverflow.com/questions/32504355/error-itms-90339-this-bundle-is-i...

It seems I have to use xcodebuild as described here to have the App Store accept
the builds:
https://stackoverflow.com/questions/32763288/ios-builds-ipa-creation-no-longe...

I'll look into that tomorrow and upload a new patch then.

https://codereview.adblockplus.org/29334710/diff/29334711/build.py
File build.py (right):

https://codereview.adblockplus.org/29334710/diff/29334711/build.py#newcode50
build.py:50: package_name = "adblockplussafariios-release-%s.ipa" % BUILD_NUMBER
On 2016/01/27 14:04:01, pavel wrote:
> Forewarning: Python noob deducting multiparam printf syntax
> 
> This could be shortened to 
> "adblockplussafariios-%s-%s.ipa" % build_type % BUILD_NUMBER
> You are enforcing those two variants in usage check anyway.

No you're quite right, I'll change that.

[Felix Dahlke, 2016-01-28 17:25:55]

Here we go, this was some major hassle. I was forced to move away from `xcrun
PackageApplication` and use `xcodebuild -exportArchive` instead. It changed
everything. Again.

https://codereview.adblockplus.org/29334710/diff/29334965/AdblockPlusSafari.x...
File AdblockPlusSafari.xcodeproj/project.pbxproj (right):

https://codereview.adblockplus.org/29334710/diff/29334965/AdblockPlusSafari.x...
AdblockPlusSafari.xcodeproj/project.pbxproj:634: E94626671C5A726800EF3119 /*
ShellScript */,
This is what seems like the best solution to a CocoaPods issue that makes the
App Store reject the resulting ipa. See:
https://github.com/CocoaPods/CocoaPods/issues/4203#issuecomment-147550871

https://codereview.adblockplus.org/29334710/diff/29334965/build.py
File build.py (right):

https://codereview.adblockplus.org/29334710/diff/29334965/build.py#newcode47
build.py:47: "ENABLE_BITCODE=NO",
I couldn't make `-exportArchive` work without doing this. I suppose it's fine
for now, we can tackle that later. Bitcode is still optional after all.

[pavel, 2016-02-01 10:18:15]

LSBCM (Scary But Correct) - "Good" does not feel like the correct word in this
instance

https://codereview.adblockplus.org/29334710/diff/29334965/build.py
File build.py (right):

https://codereview.adblockplus.org/29334710/diff/29334965/build.py#newcode57
build.py:57: "-exportOptionsPlist", build_type + "ExportOptions.plist"])
Oh wow. Seeing that -exportOptionsPlist doc was worth doubling the "xcodebuild
--help" output, it's probably THE new recommended packaging method. If just the
help output wasn't actually the only doc available...