Issue 29336233: Issue 3568 - Block pop-ups opened via an intermediate window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29336233: Issue 3568 - Block pop-ups opened via an intermediate window (Closed)

Created:
Feb. 10, 2016, 3:10 p.m. by Wladimir Palant

Modified:
Feb. 11, 2016, 1:46 p.m.

Reviewers:
Thomas Greiner

CC:
Sebastian Noack

Visibility:
Public.

Description

This is ugly - rather than relying on the browser to give us the opener we prefer to remember it ourselves, particularly for redirects that wouldn`t have this info otherwise. The consequence is that any redirect might trigger the pop-up blocker, no matter how long ago the pop-up was opened (as long as the opener window is still around). I guess that`s ok...

Patch Set 1 #

Patch Set 2 : Fixed small logic flaw #

Total comments: 2

Patch Set 3 : Fixed nit #

Created: Feb. 11, 2016, 1:44 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	lib/child/contentPolicy.js	View	1 2	2 chunks	+22 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas Greiner

LGTM https://codereview.adblockplus.org/29336233/diff/29336239/lib/child/contentPolicy.js File lib/child/contentPolicy.js (right): https://codereview.adblockplus.org/29336233/diff/29336239/lib/child/contentPolicy.js#newcode319 lib/child/contentPolicy.js:319: var opener = this._openers.get(subject); Detail: Usually, we use ...

Feb. 11, 2016, 11:06 a.m. (2016-02-11 11:06:23 UTC) #2

Wladimir Palant

Feb. 11, 2016, 1:44 p.m. (2016-02-11 13:44:45 UTC) #3

https://codereview.adblockplus.org/29336233/diff/29336239/lib/child/contentPo...
File lib/child/contentPolicy.js (right):

https://codereview.adblockplus.org/29336233/diff/29336239/lib/child/contentPo...
lib/child/contentPolicy.js:319: var opener = this._openers.get(subject);
On 2016/02/11 11:06:23, Thomas Greiner wrote:
> Detail: Usually, we use `let` over `var` to define variables.

Done.

Expand All Messages | Collapse All Messages