Issue 3676 - Configure update_issues hook

Issue 3676 - Configure update_issues hook

[mathias, 2016-02-26 18:41:59]

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manif...
File modules/hgweb/manifests/init.pp (right):

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manif...
modules/hgweb/manifests/init.pp:46: $trac_abpbot_password =
hiera('hgweb::abpbot_password', 'abpbot'),
Please ensure the $hgweb::parameter being of the exact same name as the
hiera('hgweb::parameter'), otherwise this would not be consistent with Puppet 3
behavior.

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templ...
File modules/hgweb/templates/sitescripts.ini.erb (right):

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templ...
modules/hgweb/templates/sitescripts.ini.erb:10:
issue_url_template=https://issues.adblockplus.org/ticket/{id}
Why are these options in the sitescripts.ini set up with module hgweb? I was
under the impression they are meant for the configuration file on the host the
bot is running on.

[mathias, 2016-02-26 18:45:56]

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templ...
File modules/hgweb/templates/sitescripts.ini.erb (right):

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/templ...
modules/hgweb/templates/sitescripts.ini.erb:10:
issue_url_template=https://issues.adblockplus.org/ticket/{id}
On 2016/02/26 18:41:59, mathias wrote:
> Why are these options in the sitescripts.ini set up with module hgweb? I was
> under the impression they are meant for the configuration file on the host the
> bot is running on.

Never mind, saw your comment in the ticket now.

[Felix Dahlke, 2016-02-26 18:53:16]

New patch set is up.

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manif...
File modules/hgweb/manifests/init.pp (right):

https://codereview.adblockplus.org/29337790/diff/29337791/modules/hgweb/manif...
modules/hgweb/manifests/init.pp:46: $trac_abpbot_password =
hiera('hgweb::abpbot_password', 'abpbot'),
On 2016/02/26 18:41:59, mathias wrote:
> Please ensure the $hgweb::parameter being of the exact same name as the
> hiera('hgweb::parameter'), otherwise this would not be consistent with Puppet
3
> behavior.

Oh, that wasn't even intentional, done.

[mathias, 2016-02-26 19:03:17]

LGTM.