Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338425: Issue 3499 - Remove old messaging API (Closed)

Created:
March 16, 2016, 12:33 p.m. by Wladimir Palant
Modified:
March 24, 2016, 7:28 a.m.
Reviewers:
Thomas Greiner, Erik
Visibility:
Public.

Description

Issue 3499 - Remove old messaging API Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use URLSearchParams #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -84 lines) Patch
M lib/child/bootstrap.js View 1 3 chunks +14 lines, -43 lines 1 comment Download
M lib/main.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M lib/utils.js View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
March 16, 2016, 12:33 p.m. (2016-03-16 12:33:35 UTC) #1
Erik
On 2016/03/16 12:33:35, Wladimir Palant wrote: LGTM
March 17, 2016, 5:21 a.m. (2016-03-17 05:21:33 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29338425/diff/29338426/lib/main.js File lib/main.js (right): https://codereview.adblockplus.org/29338425/diff/29338426/lib/main.js#newcode41 lib/main.js:41: Math.random() + "#" + encodeURIComponent(JSON.stringify(info)); That looks a bit ...
March 23, 2016, 2:09 p.m. (2016-03-23 14:09:20 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29338425/diff/29338426/lib/main.js File lib/main.js (right): https://codereview.adblockplus.org/29338425/diff/29338426/lib/main.js#newcode41 lib/main.js:41: Math.random() + "#" + encodeURIComponent(JSON.stringify(info)); On 2016/03/23 14:09:20, Thomas ...
March 23, 2016, 3:29 p.m. (2016-03-23 15:29:34 UTC) #4
Thomas Greiner
March 23, 2016, 3:34 p.m. (2016-03-23 15:34:22 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld