Issue 29338626: Issue 3835 - Update dependency on adblockpluscore to revision 2d4888611240

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338626: Issue 3835 - Update dependency on adblockpluscore to revision 2d4888611240 (Closed)

Created:
March 18, 2016, 2:53 p.m. by Wladimir Palant

Modified:
March 21, 2016, 3:34 p.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

This has to account for changes to InvalidFilter.reason and Subscription.title properties, also DownloadableSubscription.upgradeRequired is gone. Repository: hg.adblockplus.org/adblockplus

Patch Set 2 : Fixed updateRequired replacement #

Created: March 19, 2016, 6:57 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -17 lines)			Patch
M	chrome/content/ui/filters.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/content/ui/filters.xul	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/content/ui/filters-backup.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/ui/filters-filteractions.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/content/ui/filters-subscriptionactions.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/content/ui/filters-subscriptionview.js	View	1	3 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/content/ui/sendReport.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/content/ui/sidebar.js	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/content/ui/utils.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	dependencies	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thomas Greiner

https://codereview.adblockplus.org/29338626/diff/29338627/chrome/content/ui/filters-subscriptionview.js File chrome/content/ui/filters-subscriptionview.js (right): https://codereview.adblockplus.org/29338626/diff/29338627/chrome/content/ui/filters-subscriptionview.js#newcode331 chrome/content/ui/filters-subscriptionview.js:331: ListManager.isUpgradeRequired = function(/**Subscription*/ subscription) Where is this being used? ...

March 18, 2016, 4:43 p.m. (2016-03-18 16:43:23 UTC) #2

Wladimir Palant

March 19, 2016, 6:59 p.m. (2016-03-19 18:59:13 UTC) #3

LGTM

Expand All Messages | Collapse All Messages