Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339248: Issue 3305 - Introduce adblockplus::log::tracker and ::forwarder (Closed)

Created:
April 1, 2016, 9:12 a.m. by mathias
Modified:
April 7, 2016, 10:50 a.m.
Reviewers:
Fred
CC:
darkue
Visibility:
Public.

Description

Issue 3305 - Introduce adblockplus::log::tracker and ::forwarder

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 3305 - Fix typos in documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -112 lines) Patch
M modules/adblockplus/manifests/log.pp View 1 2 chunks +40 lines, -8 lines 0 comments Download
A modules/adblockplus/manifests/log/forwarder.pp View 1 chunk +40 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/log/tracker.pp View 1 1 chunk +59 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/log/fluentd/default.conf.erb View 1 chunk +23 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/log/fluentd/forwarder.conf.erb View 1 chunk +30 lines, -0 lines 0 comments Download
M modules/adblockplus/templates/log/fluentd/master.conf.erb View 1 chunk +2 lines, -104 lines 0 comments Download
A modules/adblockplus/templates/log/fluentd/tracker.conf.erb View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
April 1, 2016, 9:12 a.m. (2016-04-01 09:12:14 UTC) #1
Fred
https://codereview.adblockplus.org/29339248/diff/29339249/modules/adblockplus/manifests/log.pp File modules/adblockplus/manifests/log.pp (right): https://codereview.adblockplus.org/29339248/diff/29339249/modules/adblockplus/manifests/log.pp#newcode19 modules/adblockplus/manifests/log.pp:19: # A has of adblockplus::log::rotation $title => $parameter items ...
April 6, 2016, 6:03 p.m. (2016-04-06 18:03:03 UTC) #2
mathias
https://codereview.adblockplus.org/29339248/diff/29339249/modules/adblockplus/manifests/log.pp File modules/adblockplus/manifests/log.pp (right): https://codereview.adblockplus.org/29339248/diff/29339249/modules/adblockplus/manifests/log.pp#newcode19 modules/adblockplus/manifests/log.pp:19: # A has of adblockplus::log::rotation $title => $parameter items ...
April 6, 2016, 7:16 p.m. (2016-04-06 19:16:27 UTC) #3
mathias
April 7, 2016, 7:29 a.m. (2016-04-07 07:29:51 UTC) #4
Fred
April 7, 2016, 8:50 a.m. (2016-04-07 08:50:30 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld