Issue 3199 - "Firefox" string is displayed on several error messages

Issue 3199 - "Firefox" string is displayed on several error messages

Sibling review for this issue: https://codereview.adblockplus.org/29348650/

[René Jeschke, 2016-05-30 09:16:46]

On 2016/05/12 12:46:10, diegocarloslima wrote:

Sadly, the solution to this is not that easy.

Changing the string in en-US only doesn't solve the problem, as the string is
also present
in _every_ other locale. We are not 100% sure how to solve this issue. The thing
is, there
are dozens of locales in as many repositories, forking them all, modifying and
then merging
will be too time consuming, so I really do not want to go down that road.

We already have a custom mozharness fork that modifies the search settings for
all locales,
maybe this would be an option for this issue, too (i.e. modifying the strings
'on-the-fly').

[anton, 2016-09-30 06:53:11]

On 2016/05/30 09:16:46, René Jeschke wrote:
> On 2016/05/12 12:46:10, diegocarloslima wrote:
> 
> Sadly, the solution to this is not that easy.
> 
> Changing the string in en-US only doesn't solve the problem, as the string is
> also present
> in _every_ other locale. We are not 100% sure how to solve this issue. The
thing
> is, there
> are dozens of locales in as many repositories, forking them all, modifying and
> then merging
> will be too time consuming, so I really do not want to go down that road.
> 
> We already have a custom mozharness fork that modifies the search settings for
> all locales,
> maybe this would be an option for this issue, too (i.e. modifying the strings
> 'on-the-fly').

Any updates for Rene's comments?

[diegocarloslima, 2016-10-24 15:45:54]

On 2016/09/30 06:53:11, anton wrote:
> On 2016/05/30 09:16:46, René Jeschke wrote:
> > On 2016/05/12 12:46:10, diegocarloslima wrote:
> > 
> > Sadly, the solution to this is not that easy.
> > 
> > Changing the string in en-US only doesn't solve the problem, as the string
is
> > also present
> > in _every_ other locale. We are not 100% sure how to solve this issue. The
> thing
> > is, there
> > are dozens of locales in as many repositories, forking them all, modifying
and
> > then merging
> > will be too time consuming, so I really do not want to go down that road.
> > 
> > We already have a custom mozharness fork that modifies the search settings
for
> > all locales,
> > maybe this would be an option for this issue, too (i.e. modifying the
strings
> > 'on-the-fly').
> 
> Any updates for Rene's comments?

Yes, I've modified mozharness project in order to perform the required string
changes in multilocale builds. I've just updated this review description to
include its sibling

[anton, 2016-11-07 07:29:06]

On 2016/10/24 15:45:54, diegocarloslima wrote:
> On 2016/09/30 06:53:11, anton wrote:
> > On 2016/05/30 09:16:46, René Jeschke wrote:
> > > On 2016/05/12 12:46:10, diegocarloslima wrote:
> > > 
> > > Sadly, the solution to this is not that easy.
> > > 
> > > Changing the string in en-US only doesn't solve the problem, as the string
> is
> > > also present
> > > in _every_ other locale. We are not 100% sure how to solve this issue. The
> > thing
> > > is, there
> > > are dozens of locales in as many repositories, forking them all, modifying
> and
> > > then merging
> > > will be too time consuming, so I really do not want to go down that road.
> > > 
> > > We already have a custom mozharness fork that modifies the search settings
> for
> > > all locales,
> > > maybe this would be an option for this issue, too (i.e. modifying the
> strings
> > > 'on-the-fly').
> > 
> > Any updates for Rene's comments?
> 
> Yes, I've modified mozharness project in order to perform the required string
> changes in multilocale builds. I've just updated this review description to
> include its sibling

LGTM

[Felix Dahlke, 2016-12-13 13:18:25]

Shouldn't this be covered by the automated replacement logic you introduced in
https://codereview.adblockplus.org/29348650/?

[diegocarloslima, 2016-12-21 13:30:04]

On 2016/12/13 13:18:25, Felix Dahlke wrote:
> Shouldn't this be covered by the automated replacement logic you introduced in
> https://codereview.adblockplus.org/29348650/

You're right, it can be covered by the logic added in the other code review. I
added these changes though, for the situation where we aren't generating a
multi-locale build and consequently, not using mozharness. If you think is not
important to have these string changes in English-only builds, I can discard
this code review.

[Felix Dahlke, 2016-12-21 19:19:45]

I see. No incredibly strong opinion. Maybe it's helpful during an upstream merge
to stay on top of what strings we are changing. LGTM.