Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29341402: Issue 2942 - Change "clicking" to "tapping" on the second page of the first run flow of Adblock Brow (Closed)

Created:
May 13, 2016, 2:21 p.m. by diegocarloslima
Modified:
Oct. 19, 2016, 1:56 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 2942 - Change "clicking" to "tapping" on the second page of the first run flow of Adblock Browser for Android

Patch Set 1 #

Patch Set 2 : Leaving the changes for just the en-US folder as discussed previously #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5
diegocarloslima
May 13, 2016, 2:22 p.m. (2016-05-13 14:22:16 UTC) #1
René Jeschke
On 2016/05/13 14:22:16, diegocarloslima wrote: Here, as (IIRC) we already talked on IRC about, it ...
May 30, 2016, 2:02 p.m. (2016-05-30 14:02:54 UTC) #2
diegocarloslima
May 30, 2016, 4:02 p.m. (2016-05-30 16:02:53 UTC) #3
anton
https://codereview.adblockplus.org/29341402/diff/29345377/mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd File mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd (right): https://codereview.adblockplus.org/29341402/diff/29345377/mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd#newcode51 mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd:51: <!ENTITY abb_frp_step_2_text_learn "Learn more about Acceptable Ads by tapping ...
Sept. 13, 2016, 11:38 a.m. (2016-09-13 11:38:57 UTC) #4
Felix Dahlke
Sept. 15, 2016, 9:20 a.m. (2016-09-15 09:20:12 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld