Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29342791: Issue 4027 - Check only for windows build number (Closed)

Created:
May 18, 2016, 1:11 p.m. by saroyanm
Modified:
May 18, 2016, 1:26 p.m.
Visibility:
Public.

Description

Issue 4027 - Check only for windows build number

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M static/js/index.js View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
saroyanm
May 18, 2016, 1:12 p.m. (2016-05-18 13:12:01 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29342791/diff/29342792/static/js/index.js File static/js/index.js (right): https://codereview.adblockplus.org/29342791/diff/29342792/static/js/index.js#newcode41 static/js/index.js:41: var match = window.navigator.userAgent.match(/Edge\/\d+.(\d+)/); Apparently this issue isn't new ...
May 18, 2016, 1:15 p.m. (2016-05-18 13:15:31 UTC) #2
saroyanm
https://codereview.adblockplus.org/29342791/diff/29342792/static/js/index.js File static/js/index.js (right): https://codereview.adblockplus.org/29342791/diff/29342792/static/js/index.js#newcode41 static/js/index.js:41: var match = window.navigator.userAgent.match(/Edge\/\d+.(\d+)/); On 2016/05/18 13:15:31, Sebastian Noack ...
May 18, 2016, 1:18 p.m. (2016-05-18 13:18:49 UTC) #3
Oleksandr
LGTM
May 18, 2016, 1:21 p.m. (2016-05-18 13:21:42 UTC) #4
Sebastian Noack
May 18, 2016, 1:23 p.m. (2016-05-18 13:23:56 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld