Issue 3070 - Create Adblock Plus on/off switch

Issue 3070 - Create Adblock Plus on/off switch

[René Jeschke, 2016-05-30 14:00:07]

On 2016/05/23 11:08:09, diegocarloslima wrote:

Isn't this issue missing the Java part? I mean, the switch is there, the
JavaScript side is there, but where is the JavaScript function called?

[diegocarloslima, 2016-05-30 14:39:19]

On 2016/05/30 14:00:07, René Jeschke wrote:
> On 2016/05/23 11:08:09, diegocarloslima wrote:
> 
> Isn't this issue missing the Java part? I mean, the switch is there, the
> JavaScript side is there, but where is the JavaScript function called?

Actually the interface between the Java and the JavaScript code is made on the
AddOnBridge.setBoolean() method and it just requires the String that identifies
the Boolean which is defined on the preferences_abb_abp files and retrieved by
AbpCheckboxPreference

[anton, 2016-09-30 07:18:22]

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
File mobile/android/base/resources/xml-v11/preferences_abb_abp.xml (right):

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:9:
<org.adblockplus.browser.AbpCheckBoxPreference android:defaultValue="true"
i can see previously `android:title` was the first attribute so consider
reordering to make it first again for better readability

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:15:
android:title="@string/abb_pref_category_blocking">
reorder to make the first again?

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:31:
android:title="@string/abb_pref_category_exceptions">
reorder to make the first again?

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
File mobile/android/base/resources/xml/preferences_abb_abp.xml (right):

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml/preferences_abb_abp.xml:12:
android:title="@string/abb_pref_category_abp" />
reorder to make 'android:title' the first again?

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml/preferences_abb_abp.xml:15:
android:title="@string/abb_pref_category_blocking">
reorder to make 'android:title' the first again?

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml/preferences_abb_abp.xml:36:
android:title="@string/abb_pref_category_exceptions">
reorder to make 'android:title' the first again?

[diegocarloslima, 2016-10-26 12:34:17]

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
File mobile/android/base/resources/xml-v11/preferences_abb_abp.xml (right):

https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:9:
<org.adblockplus.browser.AbpCheckBoxPreference android:defaultValue="true"
On 2016/09/30 07:18:21, anton wrote:
> i can see previously `android:title` was the first attribute so consider
> reordering to make it first again for better readability

I've just looked into our sources and it seems that it has a pattern regarding
the order of precedence of the attributes in preferences xml, that would be:
1) android:key
2) android:title
3) android:summary
4) android:defaultValue
5) android:persistent
6) android:dependency

So I'll upload a patch set with the above ordering :)

[anton, 2016-11-02 14:02:16]

On 2016/10/26 12:34:17, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
> File mobile/android/base/resources/xml-v11/preferences_abb_abp.xml (right):
> 
>
https://codereview.adblockplus.org/29342912/diff/29342913/mobile/android/base...
> mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:9:
> <org.adblockplus.browser.AbpCheckBoxPreference android:defaultValue="true"
> On 2016/09/30 07:18:21, anton wrote:
> > i can see previously `android:title` was the first attribute so consider
> > reordering to make it first again for better readability
> 
> I've just looked into our sources and it seems that it has a pattern regarding
> the order of precedence of the attributes in preferences xml, that would be:
> 1) android:key
> 2) android:title
> 3) android:summary
> 4) android:defaultValue
> 5) android:persistent
> 6) android:dependency
> 
> So I'll upload a patch set with the above ordering :)

LGTM

[Felix Dahlke, 2016-12-01 17:01:49]

Code LGTM, but I've posted a comment on the issue to double check with the
relevant people that this is actually the text we want, I'm a bit sceptical. If
we do change this from "Enable Adblock Plus" to "Enable Ad Blocking" I would
argue we should also change that in the code (mainly Api.jsm).