Issue 2520 - Enable extension compatibility checking again

Issue 2520 - Enable extension compatibility checking again

[Felix Dahlke, 2016-06-16 11:40:04]

Please make sure that ad blocking still works after enabling this.

https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
File mobile/android/app/mobile.js (right):

https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
mobile/android/app/mobile.js:201: pref("extensions.checkCompatibility.nightly",
true);
I would prefer to just revert the old commit, i.e. have this be identical to
upstream again. I'm a fan of changing as little as necessary to keep the merging
effort sane.

[Felix Dahlke, 2016-09-15 08:50:57]

On 2016/06/16 11:40:04, Felix Dahlke wrote:
> Please make sure that ad blocking still works after enabling this.
> 
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> File mobile/android/app/mobile.js (right):
> 
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> mobile/android/app/mobile.js:201:
pref("extensions.checkCompatibility.nightly",
> true);
> I would prefer to just revert the old commit, i.e. have this be identical to
> upstream again. I'm a fan of changing as little as necessary to keep the
merging
> effort sane.

Any update here?

[diegocarloslima, 2016-10-21 12:36:10]

On 2016/09/15 08:50:57, Felix Dahlke wrote:
> On 2016/06/16 11:40:04, Felix Dahlke wrote:
> > Please make sure that ad blocking still works after enabling this.
> > 
> >
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> > File mobile/android/app/mobile.js (right):
> > 
> >
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> > mobile/android/app/mobile.js:201:
> pref("extensions.checkCompatibility.nightly",
> > true);
> > I would prefer to just revert the old commit, i.e. have this be identical to
> > upstream again. I'm a fan of changing as little as necessary to keep the
> merging
> > effort sane.
> 
> Any update here?

The code has been reverted to its original state and the ad blocking still
works.

[Felix Dahlke, 2016-10-21 13:18:16]

LGTM

[anton, 2016-11-09 07:14:25]

On 2016/10/21 12:36:10, diegocarloslima wrote:
> On 2016/09/15 08:50:57, Felix Dahlke wrote:
> > On 2016/06/16 11:40:04, Felix Dahlke wrote:
> > > Please make sure that ad blocking still works after enabling this.
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> > > File mobile/android/app/mobile.js (right):
> > > 
> > >
> >
>
https://codereview.adblockplus.org/29344661/diff/29344662/mobile/android/app/...
> > > mobile/android/app/mobile.js:201:
> > pref("extensions.checkCompatibility.nightly",
> > > true);
> > > I would prefer to just revert the old commit, i.e. have this be identical
to
> > > upstream again. I'm a fan of changing as little as necessary to keep the
> > merging
> > > effort sane.
> > 
> > Any update here?
> 
> The code has been reverted to its original state and the ad blocking still
> works.

LGTM