Issue 29345390: Issue 3001 - FAQ settings item should lead to the Adblock Browser FAQ

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29345390: Issue 3001 - FAQ settings item should lead to the Adblock Browser FAQ (Closed)

Created:
May 31, 2016, 9:56 a.m. by diegocarloslima

Modified:
Sept. 15, 2016, 1:06 p.m.

Reviewers:
René Jeschke, Felix Dahlke

Visibility:
Public.

Description

Issue 3001 - FAQ settings item should lead to the Adblock Browser FAQ

Patch Set 1 #

Total comments: 1

Created: May 31, 2016, 9:56 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	mobile/android/base/preferences/GeckoPreferences.java	View		1 chunk	+2 lines, -8 lines	1 comment	Download
	M	mobile/android/base/resources/xml/preferences_vendor.xml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

René Jeschke

On 2016/05/31 10:02:09, diegocarloslima wrote: LGTM

June 14, 2016, 3:34 p.m. (2016-06-14 15:34:07 UTC) #2

Felix Dahlke

https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java File mobile/android/base/preferences/GeckoPreferences.java (right): https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java#newcode915 mobile/android/base/preferences/GeckoPreferences.java:915: // See https://issues.adblockplus.org/ticket/3001 Do we actually have to remove ...

June 16, 2016, 1:33 p.m. (2016-06-16 13:33:34 UTC) #3

Felix Dahlke

On 2016/06/16 13:33:34, Felix Dahlke wrote: > https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java > File mobile/android/base/preferences/GeckoPreferences.java (right): > > https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base/preferences/GeckoPreferences.java#newcode915 ...

Sept. 15, 2016, 8:50 a.m. (2016-09-15 08:50:20 UTC) #4

diegocarloslima

Sept. 15, 2016, 1:05 p.m. (2016-09-15 13:05:47 UTC) #5

On 2016/09/15 08:50:20, Felix Dahlke wrote:
> On 2016/06/16 13:33:34, Felix Dahlke wrote:
> >
>
https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base...
> > File mobile/android/base/preferences/GeckoPreferences.java (right):
> > 
> >
>
https://codereview.adblockplus.org/29345390/diff/29345391/mobile/android/base...
> > mobile/android/base/preferences/GeckoPreferences.java:915: // See
> > https://issues.adblockplus.org/ticket/3001
> > Do we actually have to remove this code? How I see it, this'll just attempt
> > substitution, but if we don't add any substitution tags to the source
string,
> we
> > should be able to leave this code alone. Or am I missing something?
> 
> Any update here?

Actually this issue got overridden by #3220. I'm closing it now.

Expand All Messages | Collapse All Messages