Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29347154: Issue 4206 - Add opportunity to run specific test/method only (Closed)

Created:
June 30, 2016, 7:39 a.m. by anton
Modified:
June 30, 2016, 12:08 p.m.
Reviewers:
Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4206 - Add opportunity to run specific test/method only

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M README.md View 1 chunk +17 lines, -1 line 0 comments Download
M libadblockplus-android-tests/build.xml View 1 chunk +24 lines, -0 lines 3 comments Download

Messages

Total messages: 5
anton
Added custom ant target and updated README. Since the changes are minor and Rene is ...
June 30, 2016, 7:44 a.m. (2016-06-30 07:44:22 UTC) #1
Felix Dahlke
Sure, I can do it. I'm rusty, but this is simple enough :) Moved René ...
June 30, 2016, 9:14 a.m. (2016-06-30 09:14:34 UTC) #2
anton
https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-android-tests/build.xml File libadblockplus-android-tests/build.xml (right): https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-android-tests/build.xml#newcode110 libadblockplus-android-tests/build.xml:110: <arg value="class" /> On 2016/06/30 09:14:34, Felix Dahlke wrote: ...
June 30, 2016, 9:18 a.m. (2016-06-30 09:18:03 UTC) #3
anton
On 2016/06/30 09:18:03, anton wrote: > https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-android-tests/build.xml > File libadblockplus-android-tests/build.xml (right): > > https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-android-tests/build.xml#newcode110 > ...
June 30, 2016, 9:20 a.m. (2016-06-30 09:20:43 UTC) #4
Felix Dahlke
June 30, 2016, 9:27 a.m. (2016-06-30 09:27:50 UTC) #5
LGTM

https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-andr...
File libadblockplus-android-tests/build.xml (right):

https://codereview.adblockplus.org/29347154/diff/29347155/libadblockplus-andr...
libadblockplus-android-tests/build.xml:110: <arg value="class" />
On 2016/06/30 09:18:03, anton wrote:
> On 2016/06/30 09:14:34, Felix Dahlke wrote:
> > Nit: Seems like the indentation is off here - shouldn't it be indented to
the
> > same level as the line above? Same for the line below.
> 
> since "-e" stands for "then will follow key and value" i keep the same code
> style like in android ndk's build.xml where the following key/value have
> additional indentation of few spaces.

Oh right, I remember :)

Powered by Google App Engine
This is Rietveld