Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29347343: Issue 4278 - Update ABP for Firefox dependency to version 2.7.3 (Closed)

Created:
July 7, 2016, 6:48 p.m. by diegocarloslima
Modified:
Oct. 19, 2016, 1:04 p.m.
Visibility:
Public.

Description

Issue 4278 - Update ABP for Firefox dependency to version 2.7.3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -205 lines) Patch
M adblockplus/build.py View 1 chunk +19 lines, -30 lines 0 comments Download
R adblockplus/issue-2509.patch View 1 chunk +0 lines, -19 lines 0 comments Download
R adblockplus/issue-2510.patch View 1 chunk +0 lines, -154 lines 0 comments Download
M dependencies View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
diegocarloslima
July 7, 2016, 6:49 p.m. (2016-07-07 18:49:14 UTC) #1
René Jeschke
LGTM Felix, anything about 'build.py' here? And, please comment on #3389 and mark it as ...
July 12, 2016, 3:37 p.m. (2016-07-12 15:37:05 UTC) #2
Felix Dahlke
build.py looks fine, although I'm mildly unhappy with mixing indentation changes with logical changes. Nevermind ...
July 29, 2016, 11:26 a.m. (2016-07-29 11:26:48 UTC) #3
Felix Dahlke
July 29, 2016, 11:29 a.m. (2016-07-29 11:29:44 UTC) #4
On 2016/07/29 11:26:48, Felix Dahlke wrote:
> build.py looks fine, although I'm mildly unhappy with mixing indentation
changes
> with logical changes. Nevermind though, the code is simple enough.

Forgot to actually give the LGTM :) BUT: Please create a dedicated dependency
update issue as I explained in #4190 and have this commit refer to that issue
instead of #4190.

Powered by Google App Engine
This is Rietveld