Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/resources/values/dimens.xml

Issue 29348083: Issue 3769 - UI colours gone bad (Closed)
Patch Set: Adjusting comments which indicates what has being changed by this issue in upstream code Created Oct. 25, 2016, 12:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mobile/android/base/resources/values/colors.xml ('k') | mobile/android/base/resources/values/styles.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/resources/values/dimens.xml
===================================================================
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -21,17 +21,18 @@
<dimen name="browser_toolbar_height_flipper">48dp</dimen>
<dimen name="browser_toolbar_button_padding">12dp</dimen>
<dimen name="browser_toolbar_icon_width">48dp</dimen>
<dimen name="browser_toolbar_menu_icon_height">16dp</dimen>
<!-- favicon_size includes 4dp of right padding. We can't use margin (which would allow us to
specify the actual size) because that would decrease the size of our hit target. -->
<dimen name="browser_toolbar_favicon_size">21.33dip</dimen>
- <dimen name="browser_toolbar_shadow_size">2dp</dimen>
+ <!-- Using ABB dimension from style guide. See https://issues.adblockplus.org/ticket/3769 -->
+ <dimen name="browser_toolbar_shadow_size">@dimen/abb_browser_toolbar_divider</dimen>
<!-- If you update one of these values, update the others. -->
<dimen name="tablet_nav_button_width">42dp</dimen>
<dimen name="tablet_nav_button_width_half">21dp</dimen>
<dimen name="tablet_nav_button_width_plus_half">63dp</dimen>
<!-- This is the system default for the vertical padding for the divider of the TabWidget.
Used to mimic the divider padding on the tablet tabs panel back button. -->
« no previous file with comments | « mobile/android/base/resources/values/colors.xml ('k') | mobile/android/base/resources/values/styles.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld