Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349000: Issue 4240 - Put braces on each and every block (Closed)

Created:
Aug. 2, 2016, 10:59 a.m. by anton
Modified:
Sept. 15, 2016, 11:52 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4240 - Put braces on each and every block #depends on https://codereview.adblockplus.org/29344967/ what should i do for pending codereviews - update their codestyle for every codereview (if necessary) or approve the chanegs and then do codestyle changes for the new code?

Patch Set 1 #

Messages

Total messages: 3
anton
Aug. 2, 2016, 11 a.m. (2016-08-02 11:00:51 UTC) #1
diegocarloslima
On 2016/08/02 11:00:51, anton wrote: LGTM, but the changes were already performed on issue 4031 ...
Sept. 8, 2016, 11:15 p.m. (2016-09-08 23:15:19 UTC) #2
Felix Dahlke
Sept. 12, 2016, 1:54 p.m. (2016-09-12 13:54:40 UTC) #3
LGTM, would be neater to land this as an individual change, but given how little
it is I guess it's OK if you land it together with 4031.

Powered by Google App Engine
This is Rietveld