Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349720: Issue 4324 - Add Gradle build config (Closed)

Created:
Aug. 11, 2016, 1:20 p.m. by anton
Modified:
Nov. 21, 2016, 12:29 p.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4324 - Add Gradle build config The sources can be found in https://github.com/4ntoine/libadblockplus-android/commits/issue-4324

Patch Set 1 #

Total comments: 6

Patch Set 2 : added wrapper script for Windows #

Total comments: 8

Patch Set 3 : now ignoring .gradle directory #

Total comments: 14

Patch Set 4 : fixes in README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -3 lines) Patch
M .hgignore View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M README.md View 1 2 3 3 chunks +42 lines, -3 lines 0 comments Download
A build.gradle View 1 chunk +18 lines, -0 lines 0 comments Download
A gradle/wrapper/gradle-wrapper.jar View Binary file 0 comments Download
A gradle/wrapper/gradle-wrapper.properties View 1 chunk +5 lines, -0 lines 0 comments Download
A gradlew View 1 chunk +164 lines, -0 lines 0 comments Download
A gradlew.bat View 1 1 chunk +90 lines, -0 lines 0 comments Download
A libadblockplus-android-tests/build.gradle View 1 chunk +50 lines, -0 lines 0 comments Download
A libadblockplus-android/build.gradle View 1 chunk +72 lines, -0 lines 0 comments Download
A settings.gradle View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12
anton
https://codereview.adblockplus.org/29349720/diff/29349721/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29349720/diff/29349721/.hgignore#newcode20 .hgignore:20: **/build Gradle uses `build` as temporarily dir (like Maven ...
Aug. 11, 2016, 1:28 p.m. (2016-08-11 13:28:52 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29349720/diff/29353124/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29349720/diff/29353124/.hgignore#newcode20 .hgignore:20: **/build Shouldn't we also ignore the .gradle folder? https://codereview.adblockplus.org/29349720/diff/29353124/libadblockplus-android-tests/build.gradle ...
Nov. 3, 2016, 3:13 p.m. (2016-11-03 15:13:23 UTC) #2
anton
https://codereview.adblockplus.org/29349720/diff/29353124/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29349720/diff/29353124/.hgignore#newcode20 .hgignore:20: **/build On 2016/11/03 15:13:23, diegocarloslima wrote: > Shouldn't we ...
Nov. 7, 2016, 7:05 a.m. (2016-11-07 07:05:35 UTC) #3
anton
https://codereview.adblockplus.org/29349720/diff/29361761/.hgignore File .hgignore (right): https://codereview.adblockplus.org/29349720/diff/29361761/.hgignore#newcode21 .hgignore:21: .gradle took Diego's comment into account
Nov. 7, 2016, 7:21 a.m. (2016-11-07 07:21:42 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29349720/diff/29353124/libadblockplus-android-tests/build.gradle File libadblockplus-android-tests/build.gradle (right): https://codereview.adblockplus.org/29349720/diff/29353124/libadblockplus-android-tests/build.gradle#newcode24 libadblockplus-android-tests/build.gradle:24: versionName "1.3" On 2016/11/07 07:05:34, anton wrote: > On ...
Nov. 7, 2016, 1:05 p.m. (2016-11-07 13:05:06 UTC) #5
diegocarloslima
On 2016/11/07 13:05:06, diegocarloslima wrote: > https://codereview.adblockplus.org/29349720/diff/29353124/libadblockplus-android-tests/build.gradle > File libadblockplus-android-tests/build.gradle (right): > > https://codereview.adblockplus.org/29349720/diff/29353124/libadblockplus-android-tests/build.gradle#newcode24 > ...
Nov. 7, 2016, 1:06 p.m. (2016-11-07 13:06:02 UTC) #6
Felix Dahlke
Looks good, just some questions and README comments. Overall I'm not happy with duplicating build ...
Nov. 18, 2016, 7:17 a.m. (2016-11-18 07:17:43 UTC) #7
anton
https://codereview.adblockplus.org/29349720/diff/29361761/README.md File README.md (right): https://codereview.adblockplus.org/29349720/diff/29361761/README.md#newcode61 README.md:61: * Android SDK Build tools 22.0.1 On 2016/11/18 07:17:42, ...
Nov. 21, 2016, 8:15 a.m. (2016-11-21 08:15:39 UTC) #8
Felix Dahlke
https://codereview.adblockplus.org/29349720/diff/29361761/README.md File README.md (right): https://codereview.adblockplus.org/29349720/diff/29361761/README.md#newcode61 README.md:61: * Android SDK Build tools 22.0.1 On 2016/11/21 08:15:39, ...
Nov. 21, 2016, 8:55 a.m. (2016-11-21 08:55:34 UTC) #9
anton
On 2016/11/21 08:55:34, Felix Dahlke wrote: > https://codereview.adblockplus.org/29349720/diff/29361761/README.md > File README.md (right): > > https://codereview.adblockplus.org/29349720/diff/29361761/README.md#newcode61 ...
Nov. 21, 2016, 10:11 a.m. (2016-11-21 10:11:07 UTC) #10
Felix Dahlke
I see, so we have to make sure the user installs the exact version we ...
Nov. 21, 2016, 11:26 a.m. (2016-11-21 11:26:33 UTC) #11
anton
Nov. 21, 2016, 12:29 p.m. (2016-11-21 12:29:51 UTC) #12
Message was sent while issue was closed.
https://codereview.adblockplus.org/29349720/diff/29361761/README.md
File README.md (right):

https://codereview.adblockplus.org/29349720/diff/29361761/README.md#newcode78
README.md:78: This will generate *.aar library artifact in
'libadblockplus-android/build/outputs/aar/' directory.
On 2016/11/18 07:17:43, Felix Dahlke wrote:
> Unrelated, but I think it'd also be helpful to point out above in the Ant
> section where the .aar is created if one builds via Ant. But that should go
into
> a separate commit, Noissue is fine.

When compiling with Ant no aar is created. It just uses good-old copy to copy
compiled classes and resources to the application. For this the app should refer
to the library in project.properties

Powered by Google App Engine
This is Rietveld