Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29350076: Issue 4350 - Update punycode.js to 2.0.0 (Closed)

Created:
Aug. 23, 2016, 3:29 p.m. by kzar
Modified:
Aug. 23, 2016, 6:17 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4350 - Update punycode.js to 2.0.0

Patch Set 1 #

Patch Set 2 : Add license header and fix for our use #

Total comments: 4

Patch Set 3 : Addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -421 lines) Patch
M lib/punycode.js View 1 2 1 chunk +408 lines, -421 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1 Patch Set 2 : Add license header and fix for our use
Aug. 23, 2016, 3:31 p.m. (2016-08-23 15:31:01 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29350076/diff/29350079/lib/punycode.js File lib/punycode.js (right): https://codereview.adblockplus.org/29350076/diff/29350079/lib/punycode.js#newcode2 lib/punycode.js:2: * Copyright Mathias Bynens <https://mathiasbynens.be/> The MIT license header ...
Aug. 23, 2016, 4:27 p.m. (2016-08-23 16:27:06 UTC) #2
kzar
Patch Set 3 : Addressed feedback https://codereview.adblockplus.org/29350076/diff/29350079/lib/punycode.js File lib/punycode.js (right): https://codereview.adblockplus.org/29350076/diff/29350079/lib/punycode.js#newcode2 lib/punycode.js:2: * Copyright Mathias ...
Aug. 23, 2016, 4:51 p.m. (2016-08-23 16:51:14 UTC) #3
Sebastian Noack
Aug. 23, 2016, 6:04 p.m. (2016-08-23 18:04:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld