Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29355812: No Issue - Added missing paragraph to the criteria page (Closed)

Created:
Oct. 4, 2016, 3:03 p.m. by saroyanm
Modified:
Oct. 4, 2016, 5:14 p.m.
Reviewers:
juliandoucette
Visibility:
Public.

Description

No Issue - Added missing paragraph to the criteria page

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated the description #

Patch Set 3 : Moved above the footnote #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M includes/criteria/size.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Oct. 4, 2016, 3:03 p.m. (2016-10-04 15:03:51 UTC) #1
juliandoucette
One minor issue. See below. https://codereview.adblockplus.org/29355812/diff/29355813/includes/criteria/size.md File includes/criteria/size.md (right): https://codereview.adblockplus.org/29355812/diff/29355813/includes/criteria/size.md#newcode14 includes/criteria/size.md:14: {{total-ad-space[Paragraph in "General criteria"] ...
Oct. 4, 2016, 3:08 p.m. (2016-10-04 15:08:17 UTC) #2
saroyanm
https://codereview.adblockplus.org/29355812/diff/29355813/includes/criteria/size.md File includes/criteria/size.md (right): https://codereview.adblockplus.org/29355812/diff/29355813/includes/criteria/size.md#newcode14 includes/criteria/size.md:14: {{total-ad-space[Paragraph in "General criteria"] All ads that are placed ...
Oct. 4, 2016, 3:11 p.m. (2016-10-04 15:11:52 UTC) #3
juliandoucette
Oct. 4, 2016, 4:16 p.m. (2016-10-04 16:16:58 UTC) #4
> Done.

LGTM

Powered by Google App Engine
This is Rietveld