No Issue - Drafted existing CSS coding style guide

It's quite inconvenient to jump around between:

- Adblock Plus Coding Style
  - Precedence
  - Consistency
  - General
  - HTML and CSS
- Mozilla Coding sytle
  - General practices
  - Naming and formatting code
- Google HTML/CSS Style Guide

to determine CSS coding style rules.

As a result, I reviewed these documents, and combined/simplified their rules into one list.

I hope that we can use it to:

1. Identify undocumented rules
2. Remove incorrect rules
3. Identify rules that we want to change
4. Confirm linter config correctness

[Felix Dahlke, 2016-10-06 11:29:24]

I don't think I'm the right person to review this, moved myself to CC. Thomas
and Manvel came up with our current style guide
(https://adblockplus.org/coding-style#html-css) and I'll most likely be fine
with whatever you three agree on.

[juliandoucette, 2016-10-06 11:38:16]

On 2016/10/06 11:29:24, Felix Dahlke wrote:
> I don't think I'm the right person to review this, moved myself to CC. Thomas
> and Manvel came up with our current style guide
> (https://adblockplus.org/coding-style#html-css) and I'll most likely be fine
> with whatever you three agree on.

Sorry Felix,

I just used your name to upload the review before I finished the description and
added CC and reviewers.

[juliandoucette, 2016-10-06 11:44:09]

It's quite inconvenient to jump around between: 

- Adblock Plus Coding Style 
  - Precedence 
  - Consistency 
  - General 
  - HTML and CSS 
- Mozilla Coding sytle 
  - General practices 
  - Naming and formatting code 
- Google HTML/CSS Style Guide 

to determine CSS coding style rules. 

As a result, I reviewed these documents, and combined/simplified their rules
into one list. 

I hope that we can use it to: 

1. Identify undocumented rules 
2. Remove incorrect rules 
3. Identify rules that we want to change 
4. Confirm linter config correctness

[Thomas Greiner, 2016-10-07 17:19:45]

Since there's no ticket associated with this review, I'm slightly confused about
the context of this change: Is this meant to be a replacement for our existing
CSS/HTML coding style on adblockplus.org/coding-style?

[juliandoucette, 2016-10-07 18:57:36]

On 2016/10/07 17:19:45, Thomas Greiner wrote:
> Since there's no ticket associated with this review, I'm slightly confused
about
> the context of this change: Is this meant to be a replacement for our existing
> CSS/HTML coding style on adblockplus.org/coding-style?

Not yet. And sorry for the confusion.

- The issue: "It's quite inconvenient to jump around between ... to determine
CSS coding style rules."
    - This relates to our csscomb / csslint review
    - This is not *yet* a "bug" or a "change" request
    - If applicable, I will create a ticket and update the title/description
- The solution: "As a result, I reviewed these documents, and
combined/simplified their rules into one list."
    - I created this for myself
    - It's not clear yet if or how we should update the page on adblockplus.org
- The ask: I want you to review `css.md` and comment if you:
    - Think a rule is missing ("Identify undocumented rules")
    - Think a rule is incorrect ("Remove incorrect rules")
    - Think a rule should change ("Identify rules that we want to change")
- Why a code review? Because:
    - It supports commenting inline
    - It notifies us of updates
    - It's transparent (as opposed to a private Google Doc)

[juliandoucette, 2016-10-08 12:20:13]

(I would actually suggest we put this in the Trac wiki like Help/Guide)

[juliandoucette, 2016-10-11 17:41:56]

I'm going to close this review and bring up the issue mentioned in the next
Frontend Developer meeting.