Issue 29360004: No issue - Created htmlhintrc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29360004: No issue - Created htmlhintrc (Closed)

Created:
Oct. 27, 2016, 12:50 p.m. by juliandoucette

Modified:
Jan. 30, 2017, 11:28 a.m.

Reviewers:
Lisa, Thomas Greiner, Erik, saroyanm

CC:
Felix Dahlke, ppastour, martin

Visibility:
Public.

Description

I chose htmlhint because there is a linter-* plugin in Atoms plugin repository (I recommended Atom to @Lisa for writing HTML and Markdown). ## Usage ### CLI - `npm i htmlhint -g` - `htmlhint --config /path/to/config /path/to/file.html ### Atom - Install linter-htmlhint - Link `codingtools/htmlhintrc.json` to `$HOME/htmlhintrc`

Patch Set 1 #

Patch Set 2 : Removed doctype and title rules #

Created: Oct. 27, 2016, 1:04 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	A	htmlhintrc.json	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

juliandoucette

Removed doctype first and title in head rules because they are not necessary in HTML ...

Oct. 27, 2016, 1:04 p.m. (2016-10-27 13:04:35 UTC) #2

juliandoucette

Jan. 30, 2017, 11:28 a.m. (2017-01-30 11:28:10 UTC) #4

Message was sent while issue was closed.

I closed this review because:

- I didn't find htmlhint very useful after all
  - because it doesn't have many rules
  - because it doesn't validate html (like W3C validate)
  - because modern editors/IDEs seem to find errors more effectively
- There doesn't seem to be enough interest in having this linter config in
codingtools

Expand All Messages | Collapse All Messages