Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29361733: Issue 4602 - Change 'Samsung Browser' wording to 'Samsung Internet' (Closed)

Created:
Nov. 4, 2016, 3:52 p.m. by diegocarloslima
Modified:
Jan. 4, 2017, 3:01 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4602 - Change 'Samsung Browser' wording to 'Samsung Internet'

Patch Set 1 #

Patch Set 2 : Also changing on README #

Total comments: 2

Patch Set 3 : Adding string change in update dialog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M README.md View 1 1 chunk +2 lines, -2 lines 0 comments Download
M res/raw/sbrowser_dialog.html View 1 chunk +2 lines, -2 lines 0 comments Download
M res/values/strings.xml View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
Nov. 4, 2016, 4:55 p.m. (2016-11-04 16:55:06 UTC) #1
anton
https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml File res/values/strings.xml (left): https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml#oldcode22 res/values/strings.xml:22: <string name="sbrowser_dialog_title">Update your browser</string> I'm always confused with such ...
Nov. 7, 2016, 7:27 a.m. (2016-11-07 07:27:57 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml File res/values/strings.xml (left): https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml#oldcode22 res/values/strings.xml:22: <string name="sbrowser_dialog_title">Update your browser</string> On 2016/11/07 07:27:56, anton wrote: ...
Nov. 7, 2016, 10:28 a.m. (2016-11-07 10:28:56 UTC) #3
anton
On 2016/11/07 10:28:56, diegocarloslima wrote: > https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml > File res/values/strings.xml (left): > > https://codereview.adblockplus.org/29361733/diff/29361737/res/values/strings.xml#oldcode22 > ...
Dec. 5, 2016, 11:46 a.m. (2016-12-05 11:46:35 UTC) #4
Felix Dahlke
Dec. 20, 2016, 9:19 p.m. (2016-12-20 21:19:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld