Issue 29364548: Issue 4188 - Update libadblockplus-android to use the latest libadblockplus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29364548: Issue 4188 - Update libadblockplus-android to use the latest libadblockplus (Closed)

Created:
Nov. 25, 2016, 12:36 p.m. by anton

Modified:
Dec. 5, 2016, 5:54 p.m.

Reviewers:
diegocarloslima, Felix Dahlke

CC:
sergei, René Jeschke

Visibility:
Public.

Description

Issue 4188 - Update libadblockplus-android to use the latest libadblockplus Compiled libadblockplus git:a54669617f0dff8f99431de6525f09879085cc99 (some binaries were not uploaded with Rietveld upload error 500)

Patch Set 1 #

Patch Set 2 : recompiled for libadblockplus git:70ac2462a5e6437b5b1f58455b2e0172c33cc432. Duplicated on gihtub: https://github.com/4ntoine/libadblockplus-binaries/commit/5b9c89920c72f0b980a268bc80b73705c29a034a #

Total comments: 2

Created: Dec. 5, 2016, 11:20 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -127 lines)			Patch
M	.gitignore	View	1	1 chunk	+2 lines, -1 line	2 comments	Download
M	android_armeabi-v7a/libadblockplus.a	View		Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_base.a	View		Binary file		0 comments	Download
M	android_armeabi-v7a/libv8_snapshot.a	View	1	Binary file		0 comments	Download
M	android_x86/libadblockplus.a	View		Binary file		0 comments	Download
M	android_x86/libv8_base.a	View		Binary file		0 comments	Download
M	android_x86/libv8_snapshot.a	View	1	Binary file		0 comments	Download
M	include/AdblockPlus.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/AppInfo.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/DefaultFileSystem.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/DefaultLogSystem.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/DefaultWebRequest.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/FileSystem.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/FilterEngine.h	View	1	11 chunks	+39 lines, -19 lines	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	1	5 chunks	+45 lines, -8 lines	0 comments	Download
M	include/AdblockPlus/JsValue.h	View	1	4 chunks	+12 lines, -4 lines	0 comments	Download
M	include/AdblockPlus/LogSystem.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/AdblockPlus/Notification.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	include/AdblockPlus/ReferrerMapping.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
R	include/AdblockPlus/V8ValueHolder.h	View	1	1 chunk	+0 lines, -82 lines	0 comments	Download
M	include/AdblockPlus/WebRequest.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

LGTM, with that unrelated change removed. https://codereview.adblockplus.org/29364548/diff/29366818/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29364548/diff/29366818/.gitignore#newcode2 .gitignore:2: **/.DS_Store Looks like ...

Dec. 5, 2016, 1:58 p.m. (2016-12-05 13:58:59 UTC) #2

anton

Dec. 5, 2016, 2:05 p.m. (2016-12-05 14:05:03 UTC) #3

https://codereview.adblockplus.org/29364548/diff/29366818/.gitignore
File .gitignore (right):

https://codereview.adblockplus.org/29364548/diff/29366818/.gitignore#newcode2
.gitignore:2: **/.DS_Store
On 2016/12/05 13:58:59, Felix Dahlke wrote:
> Looks like an unrelated change.

Acknowledged.

Expand All Messages | Collapse All Messages