Issue 4681 - Move URL Fixer first-run page into the extension

Issue 4681 - Move URL Fixer first-run page into the extension

[Wladimir Palant, 2016-12-01 13:13:44]

Not as bad as it looks - there aren't actually many changes here. It's mostly
files that have been copied from the website unchanged.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css:38: background-image:
url('fancybox.png');
I changed the URL here and for the other links, all images are in the same
directory now.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css:328: .fancybox-ie6
#fancybox-close { background: transparent; filter:
progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_close.png',
sizingMethod='scale'); }
I didn't bother with these IE6 paths (these weren't correct before either).

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/index.html (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/index.html:9: <script type="text/javascript"
src="fancybox/jquery.fancybox-1.3.4.pack.js"></script>
I changed the paths above to relative, same with the screenshots below.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/index.html:20: });
There was some additional logic related to the data collection opt-in here - I
removed it along with the corresponding text block, we are removing data
collection functionality.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/index.html:109: <a
href="https://addons.mozilla.org/addon/url-fixer/privacy/">Privacy Policy</a>
There was an imprint link here, I removed it given that this isn't a web page
any more.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/style.css (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/style.css:5: @font-face {font-family:
'DesignosaurRegular';src: url('designosaur-regular-webfont.woff')
format('woff');font-weight: normal;font-style: normal;}
I removed font formats other than WOFF here.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/style.css:11: body, html {font-family:Arial, Helvetica,
sans-serif;font-size:12px;background-color:#E7F0F9;}
This was originally using a one-pixel background image - I extracted the color
from the image instead.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/style.css:51: /* -- */
This document was considerably larger originally, I removed everything that
obviously didn't apply to the first-run page.

[Thomas Greiner, 2016-12-07 16:08:32]

All the changes seem reasonable. There's just one small comment I added.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css:328: .fancybox-ie6
#fancybox-close { background: transparent; filter:
progid:DXImageTransform.Microsoft.AlphaImageLoader(src='fancybox/fancy_close.png',
sizingMethod='scale'); }
On 2016/12/01 13:13:43, Wladimir Palant wrote:
> I didn't bother with these IE6 paths (these weren't correct before either).

Fair enough.

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/index.html (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/index.html:107: Open-source software released under <a
href="http://www.mozilla.org/MPL/1.1/">Mozilla Public License</a>
We're using GPLv3 for URL Fixer, aren't we? Based on this it looks like we
forgot to mention that on the website when we changed its license.

[Wladimir Palant, 2016-12-08 13:02:23]

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
File chrome/content/firstrun/index.html (right):

https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firs...
chrome/content/firstrun/index.html:107: Open-source software released under <a
href="http://www.mozilla.org/MPL/1.1/">Mozilla Public License</a>
On 2016/12/07 16:08:32, Thomas Greiner wrote:
> We're using GPLv3 for URL Fixer, aren't we? Based on this it looks like we
> forgot to mention that on the website when we changed its license.

Done.

[Thomas Greiner, 2016-12-08 14:25:19]

LGTM