Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29366643: Issue 4682 - Remove typo collection functionality from URL Fixer (Closed)

Created:
Dec. 1, 2016, 1:23 p.m. by Wladimir Palant
Modified:
April 11, 2017, 10:28 a.m.
Reviewers:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/urlfixer
Visibility:
Public.

Description

Issue 4682 - Remove typo collection functionality from URL Fixer

Patch Set 1 #

Patch Set 2 : Removed call to non-existant function #

Total comments: 7

Patch Set 3 : Removed some leftovers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-14 lines, -466 lines) Patch
M chrome/content/options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/content/options.xul View 1 1 chunk +1 line, -5 lines 0 comments Download
R chrome/content/typedItOptIn.js View 1 chunk +0 lines, -41 lines 0 comments Download
R chrome/content/typedItOptIn.xul View 1 chunk +0 lines, -47 lines 0 comments Download
R chrome/locale/ar-SA/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/ca-AD/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/cs-CZ/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/da-DK/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/da/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/de/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/de/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/locale/en-US/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/en-US/typedItOptIn.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/es-ES/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/fi-FI/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/fr/locale.dtd View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
R chrome/locale/gl-ES/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/he-IL/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/he-IL/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/hu-HU/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/it-IT/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/ja-JP/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/ja-JP/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/ko-KR/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/ko-KR/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/lt-LT/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/mk-MK/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/nl/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/nl/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/pl-PL/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/pl/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/pt-BR/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/pt-BR/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/pt-PT/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/pt-PT/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/ru-RU/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/ru-RU/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/sk-SK/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/sq-AL/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/sr/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/sr/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/sv-SE/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/sv-SE/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/tr-TR/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/locale/uk-UA/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/vi/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/vi/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/zh-CN/locale.dtd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/locale/zh-CN/options.dtd View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
R chrome/locale/zh-TW/locale.dtd View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
R chrome/skin/typedItOptIn.css View 1 chunk +0 lines, -10 lines 0 comments Download
M lib/main.js View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M lib/prefs.json View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
R lib/typoCollector.js View 1 chunk +0 lines, -224 lines 0 comments Download
M lib/typoFixer.js View 3 chunks +0 lines, -5 lines 0 comments Download
M lib/typoNetError.js View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Dec. 1, 2016, 1:23 p.m. (2016-12-01 13:23:43 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.xul File chrome/content/options.xul (right): https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.xul#newcode27 chrome/content/options.xul:27: onload="updateList();" Missed that - initCheckboxes() was being called of ...
Dec. 1, 2016, 1:54 p.m. (2016-12-01 13:54:37 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.js File chrome/content/options.js (left): https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.js#oldcode26 chrome/content/options.js:26: E("domainOptIn").checked = Prefs.domainOptIn; What about the preference's default value ...
Dec. 7, 2016, 3:43 p.m. (2016-12-07 15:43:35 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.js File chrome/content/options.js (left): https://codereview.adblockplus.org/29366643/diff/29366659/chrome/content/options.js#oldcode26 chrome/content/options.js:26: E("domainOptIn").checked = Prefs.domainOptIn; On 2016/12/07 15:43:34, Thomas Greiner wrote: ...
Dec. 8, 2016, 12:48 p.m. (2016-12-08 12:48:14 UTC) #4
Thomas Greiner
Dec. 8, 2016, 2:22 p.m. (2016-12-08 14:22:54 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld