Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366707: Issue 3574 - Remove obsolete sshkey realization in class statsmaster (Closed)

Created:
Dec. 1, 2016, 4:45 p.m. by mathias
Modified:
Dec. 5, 2016, 7:01 a.m.
Reviewers:
f.lopez, f.nicolaisen
CC:
Fred
Visibility:
Public.

Description

Became obsolete in the context of https://issues.adblockplus.org/ticket/3638 with the introduction of modules/adblockplus/host/statsmaster.pp --

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M modules/statsmaster/manifests/init.pp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mathias
Dec. 1, 2016, 4:45 p.m. (2016-12-01 16:45:16 UTC) #1
f.lopez
On 2016/12/01 16:45:16, mathias wrote: LGTM
Dec. 2, 2016, 2:47 p.m. (2016-12-02 14:47:53 UTC) #2
f.nicolaisen
I think I get the reasoning (I see the lines but not the picture), but ...
Dec. 2, 2016, 3:02 p.m. (2016-12-02 15:02:57 UTC) #3
mathias
On 2016/12/02 15:02:57, f.nicolaisen wrote: > Another thing: Do you have a commit message we ...
Dec. 2, 2016, 3:28 p.m. (2016-12-02 15:28:13 UTC) #4
f.nicolaisen
Dec. 2, 2016, 3:32 p.m. (2016-12-02 15:32:42 UTC) #5
On 2016/12/02 15:28:13, mathias wrote:
> On 2016/12/02 15:02:57, f.nicolaisen wrote:
> > Another thing: Do you have a commit message we can review to go with it?
> 
> The title of this very review (plus the "in" which I forgot during the upload
> but added in the GUI afterwards). Note that the line patched out has no effect
> anymore either way, there is no sshkey resource with the associated tag
anyway.

OK, LGTM then.

Powered by Google App Engine
This is Rietveld