Issue 29366814: Noissue - Fix adblockplus::host $ensure = "absent" support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29366814: Noissue - Fix adblockplus::host $ensure = "absent" support (Closed)

Created:
Dec. 5, 2016, 10:49 a.m. by mathias

Modified:
Dec. 5, 2016, 2:59 p.m.

Reviewers:
f.lopez

CC:
Fred, f.nicolaisen

Visibility:
Public.

Description

Noissue - Fix adblockplus::host $ensure = "absent" support

Patch Set 2 : Noissue - Include $ensure = "absent" example in the host class documentation #

Created: Dec. 5, 2016, 12:03 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	modules/adblockplus/manifests/host.pp	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
	M	modules/private-stub/hiera/hosts.yaml	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

f.lopez

Also, the documentation of the host can be updated using the "absent" value without an ...

Dec. 5, 2016, 11:49 a.m. (2016-12-05 11:49:21 UTC) #2

mathias

https://codereview.adblockplus.org/29366814/diff/29366815/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (right): https://codereview.adblockplus.org/29366814/diff/29366815/modules/private-stub/hiera/hosts.yaml#newcode4 modules/private-stub/hiera/hosts.yaml:4: ensure: "absent" On 2016/12/05 11:49:21, f.lopez wrote: > I ...

Dec. 5, 2016, 12:04 p.m. (2016-12-05 12:04:21 UTC) #4

f.lopez

Dec. 5, 2016, 1:38 p.m. (2016-12-05 13:38:14 UTC) #5

On 2016/12/05 12:04:21, mathias wrote:
>
https://codereview.adblockplus.org/29366814/diff/29366815/modules/private-stu...
> File modules/private-stub/hiera/hosts.yaml (right):
> 
>
https://codereview.adblockplus.org/29366814/diff/29366815/modules/private-stu...
> modules/private-stub/hiera/hosts.yaml:4: ensure: "absent"
> On 2016/12/05 11:49:21, f.lopez wrote:
> > I don't see why the example is here IMO it should only be documented without
> > actually modifying the configuration of the hosts.
> 
> Well, the example serves two purposes: Being a smoke-test and, of course, an
> example. Also, note that a patch-set in the not-so-far-future will remove the
> servers: key below, so that it's items become items of the adblockplus::host
key
> as well (as soon as the base=>host migration is complete).

Ok then, I can confirm it works as intended, LGTM.

Expand All Messages | Collapse All Messages