Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366969: [adblockplusui] Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui (Closed)

Created:
Dec. 7, 2016, 7:48 a.m. by wspee
Modified:
Dec. 22, 2016, 8:47 a.m.
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui

Patch Set 1 #

Patch Set 2 : Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui #

Patch Set 3 : Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui #

Patch Set 4 : Moved antiadblockInit.js related changes to adblockplusui and used ext.i18n.getMessage instead #

Patch Set 5 : Removed non en-US translations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
A lib/antiadblockInit.js View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A locale/en-US/antiadblockInit.json View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5
wspee
See also: https://codereview.adblockplus.org/29366966/
Dec. 7, 2016, 7:55 a.m. (2016-12-07 07:55:51 UTC) #1
wspee
Removed @thomas as the reviewer because he's on vacation.
Dec. 19, 2016, 4:09 p.m. (2016-12-19 16:09:28 UTC) #2
wspee
Removed non en-US translations as suggested in [0]. [0] https://codereview.adblockplus.org/29369232/#msg4
Dec. 20, 2016, 10:25 a.m. (2016-12-20 10:25:59 UTC) #3
Felix Dahlke
LGTM
Dec. 20, 2016, 3:04 p.m. (2016-12-20 15:04:48 UTC) #4
Sebastian Noack
Dec. 21, 2016, 1:09 p.m. (2016-12-21 13:09:13 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld