Issue 29367240: Issue 3638 - Generate statsmaster filter mirror configuration with concat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29367240: Issue 3638 - Generate statsmaster filter mirror configuration with concat (Closed)

Created:
Dec. 12, 2016, 10 a.m. by mathias

Modified:
Dec. 12, 2016, 11:09 a.m.

Reviewers:
f.lopez

CC:
Fred, f.nicolaisen

Visibility:
Public.

Description

Issue 3638 - Generate statsmaster filter mirror configuration with concat

Patch Set 1 #

Total comments: 2

Created: Dec. 12, 2016, 10 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
	M	modules/adblockplus/manifests/host/statsmaster.pp	View		1 chunk	+19 lines, -0 lines	0 comments	Download
	M	modules/statsmaster/templates/sitescripts.ini.erb	View		2 chunks	+1 line, -15 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

f.lopez

Verified working, but as ferris pointed in another codereview, should we fix style when we ...

Dec. 12, 2016, 10:21 a.m. (2016-12-12 10:21:53 UTC) #2

mathias

In general one should just create a single commit fixing one set of style-related issues ...

Dec. 12, 2016, 11:02 a.m. (2016-12-12 11:02:56 UTC) #3

f.lopez

Dec. 12, 2016, 11:05 a.m. (2016-12-12 11:05:32 UTC) #4

On 2016/12/12 11:02:56, mathias wrote:
> In general one should just create a single commit fixing one set of
> style-related issues in a particular module. As reference one use
> https://issues.adblockplus.org/ticket/3576 and some useful commit message.
> 
>
https://codereview.adblockplus.org/29367240/diff/29367241/modules/statsmaster...
> File modules/statsmaster/templates/sitescripts.ini.erb (right):
> 
>
https://codereview.adblockplus.org/29367240/diff/29367241/modules/statsmaster...
> modules/statsmaster/templates/sitescripts.ini.erb:23: 
> On 2016/12/12 10:21:52, f.lopez wrote:
> > This is an unrelated change for the ticket you are addressing, are we still
> > following this policy or we should just fix this kind of things when we find
> > them? If not, let's create a ticket to fix the styles and stuff like this.
> 
> Actually, it is not an unrelated change. I wanted the concat::fragments that
are
> appended to be spaced from the initial content by a single line.

Fair enough, LGTM!

Expand All Messages | Collapse All Messages