Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367494: Issue 3065 - Introduce support for host-specific operating systems (Closed)

Created:
Dec. 14, 2016, 3:07 p.m. by mathias
Modified:
Dec. 14, 2016, 3:37 p.m.
Reviewers:
f.lopez, f.nicolaisen
CC:
Fred, f.nicolaisen
Visibility:
Public.

Description

Issue 3065 - Introduce support for host-specific operating systems

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -82 lines) Patch
M Vagrantfile View 1 chunk +103 lines, -57 lines 0 comments Download
A hiera/roles/default.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/host.pp View 2 chunks +5 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +33 lines, -25 lines 0 comments Download

Messages

Total messages: 3
mathias
Dec. 14, 2016, 3:07 p.m. (2016-12-14 15:07:14 UTC) #1
f.lopez
On 2016/12/14 15:07:14, mathias wrote: Tested... LGTM!
Dec. 14, 2016, 3:13 p.m. (2016-12-14 15:13:27 UTC) #2
f.nicolaisen
Dec. 14, 2016, 3:36 p.m. (2016-12-14 15:36:55 UTC) #3
On 2016/12/14 15:13:27, f.lopez wrote:
> On 2016/12/14 15:07:14, mathias wrote:
> 
> Tested... LGTM!

LGTM too, if you're waiting for a 2nd op :)

Powered by Google App Engine
This is Rietveld