Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367500: Issue 3065 - Introduce adblockplus::puppet::master module (Closed)

Created:
Dec. 14, 2016, 4:02 p.m. by mathias
Modified:
Dec. 15, 2016, 8:01 a.m.
Reviewers:
f.lopez, f.nicolaisen
CC:
Fred
Visibility:
Public.

Description

Issue 3065 - Introduce adblockplus::puppet::master module

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -0 lines) Patch
A hiera/roles/puppetmaster.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/init.pp View 1 chunk +1 line, -0 lines 0 comments Download
A modules/adblockplus/manifests/puppet.pp View 1 chunk +49 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/puppet/master.pp View 1 chunk +50 lines, -0 lines 1 comment Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mathias
Dec. 14, 2016, 4:03 p.m. (2016-12-14 16:03:00 UTC) #1
f.lopez
tested... LGTM https://codereview.adblockplus.org/29367500/diff/29367501/modules/adblockplus/manifests/puppet/master.pp File modules/adblockplus/manifests/puppet/master.pp (right): https://codereview.adblockplus.org/29367500/diff/29367501/modules/adblockplus/manifests/puppet/master.pp#newcode37 modules/adblockplus/manifests/puppet/master.pp:37: ensure_resource('package', 'puppetmaster', $package) +1 for using ensure_resources ...
Dec. 14, 2016, 4:12 p.m. (2016-12-14 16:12:37 UTC) #2
f.nicolaisen
Dec. 14, 2016, 4:26 p.m. (2016-12-14 16:26:33 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld