Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367556: Issue 3065 - Refactor adblockplus::puppet module to include Puppet patches (Closed)

Created:
Dec. 15, 2016, 9:58 a.m. by mathias
Modified:
Dec. 15, 2016, 12:14 p.m.
Reviewers:
f.lopez
CC:
Fred, f.nicolaisen
Visibility:
Public.

Description

Issue 3065 - Refactor adblockplus::puppet module to include Puppet patches

Patch Set 1 #

Total comments: 1

Patch Set 2 : (remove accidental changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -32 lines) Patch
M modules/adblockplus/manifests/init.pp View 1 1 chunk +0 lines, -1 line 0 comments Download
M modules/adblockplus/manifests/puppet.pp View 1 chunk +31 lines, -29 lines 0 comments Download
A modules/adblockplus/manifests/puppet/agent.pp View 1 chunk +51 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/puppet/master.pp View 1 chunk +4 lines, -2 lines 0 comments Download
M modules/private-stub/hiera/base.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
mathias
Dec. 15, 2016, 9:58 a.m. (2016-12-15 09:58:45 UTC) #1
mathias
Dec. 15, 2016, 10 a.m. (2016-12-15 10:00:34 UTC) #2
mathias
https://codereview.adblockplus.org/29367556/diff/29367557/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29367556/diff/29367557/modules/adblockplus/manifests/init.pp#newcode119 modules/adblockplus/manifests/init.pp:119: 'owner' => 'root', Accidental change, removed this one.
Dec. 15, 2016, 10:01 a.m. (2016-12-15 10:01:10 UTC) #3
f.lopez
Dec. 15, 2016, 11:54 a.m. (2016-12-15 11:54:16 UTC) #4
On 2016/12/15 10:01:10, mathias wrote:
>
https://codereview.adblockplus.org/29367556/diff/29367557/modules/adblockplus...
> File modules/adblockplus/manifests/init.pp (right):
> 
>
https://codereview.adblockplus.org/29367556/diff/29367557/modules/adblockplus...
> modules/adblockplus/manifests/init.pp:119: 'owner' => 'root',
> Accidental change, removed this one.

LGTM!

Powered by Google App Engine
This is Rietveld