Issue 4234 - New discourse module based on docker

Issue 4234 - New discourse module based on docker

Introduce a new module for installing discourse based on their
recommended Beginner Docker install guide [1].

The next steps are to run a community forum based on this module, and
later on migrate the intraforum to run using the same module.

The patch assumes that it is run on a base-image that supports modern
versions of docker (i.e. Debian Jessie).

Note that this patch is a subset of the work Wladimir did to
upgrade to the current way of installing the intraforum [2].

[1] https://github.com/discourse/discourse/blob/master/docs/INSTALL.md
[2] https://codereview.adblockplus.org/29347356/

[f.lopez, 2017-01-03 20:22:45]

We also need documentation, we might not be writing documentation for existing
modules but for new ones we need to have it from the beginning

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
File modules/discourse_docker/files/site.conf (right):

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/files/site.conf:10: 
this can be accomplished with the nginx::hostconfig resource of the nginx module

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
File modules/discourse_docker/manifests/init.pp (right):

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:2: $domain,
we need to set default values for these variables, for example:

$domain = hiera('discourse_docker::domain', 'undef')

I'm not sure if $domain makes sense but the other absolutely does, so in this
way we make them compatible with hiera as well

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:4: $private_key,
we might want to add a $ensure variable so we can also make it "absent"

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:22: 
for these packages we can use the `ensure_resource` function from the stdlib
module so we can send them via hiera as well, just like adblockplus or fail2ban
module does.

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:75: }
this can be inside a conditional from `service {'docker':` to here since these
steps are only executed if the resource is present, otherwise it will fail (we
need a $present variable)

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
File modules/discourse_docker/templates/app.yml.erb (right):

https://codereview.adblockplus.org/29370691/diff/29370692/modules/discourse_d...
modules/discourse_docker/templates/app.yml.erb:82: #- git clone
https://github.com/discourse/docker_manager.git
are these lines necessary if the command is commented?

[f.nicolaisen, 2017-01-06 10:40:19]

I uploaded patch set 2 now which addresses most of the comments. Note that this
patch now requires on having a docker class that installs docker!

[f.lopez, 2017-01-06 14:37:54]

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
File modules/discourse_docker/manifests/init.pp (right):

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:48: 
we don't use a new line after the documentation

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
File modules/discourse_docker/templates/app.yml.erb (right):

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
modules/discourse_docker/templates/app.yml.erb:82: #- git clone
https://github.com/discourse/docker_manager.git
we can as well comment all this since we are not installing plugins, it will
server as a documentation

[f.nicolaisen, 2017-01-06 15:36:03]

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
File modules/discourse_docker/manifests/init.pp (right):

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:48: 
On 2017/01/06 14:37:54, f.lopez wrote:
> we don't use a new line after the documentation

Acknowledged.

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
File modules/discourse_docker/templates/app.yml.erb (right):

https://codereview.adblockplus.org/29370691/diff/29370776/modules/discourse_d...
modules/discourse_docker/templates/app.yml.erb:82: #- git clone
https://github.com/discourse/docker_manager.git
On 2017/01/06 14:37:54, f.lopez wrote:
> we can as well comment all this since we are not installing plugins, it will
> server as a documentation

Acknowledged.

[f.lopez, 2017-01-06 15:37:31]

https://codereview.adblockplus.org/29370691/diff/29370814/modules/discourse_d...
File modules/discourse_docker/manifests/init.pp (right):

https://codereview.adblockplus.org/29370691/diff/29370814/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:116: }
are we missing a new line here?

[f.nicolaisen, 2017-01-06 15:41:06]

Uploaded new patch set 4

https://codereview.adblockplus.org/29370691/diff/29370814/modules/discourse_d...
File modules/discourse_docker/manifests/init.pp (right):

https://codereview.adblockplus.org/29370691/diff/29370814/modules/discourse_d...
modules/discourse_docker/manifests/init.pp:116: }
On 2017/01/06 15:37:31, f.lopez wrote:
> are we missing a new line here?

Acknowledged.

[f.lopez, 2017-01-06 15:48:03]

LGTM, I still think we can create a ticket or something to improve the module,
this can be tackled later of course.