Issue 4505 - Add translations

Issue 4505 - Add translations

[Felix Dahlke, 2017-01-06 09:31:48]

LGTM (with one question), but here's another one: What about upload to and
download from Crowdin? In ABB we have translations.py for that.

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings.xml
File res/values/strings.xml (right):

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings....
res/values/strings.xml:21: <string name="aa_dialog_message"><![CDATA[Annoying
ads are always blocked, while nonintrusive ads are displayed by default. You can
change this setting at any time by configuring the <b>Allow some nonintrusive
ads</b> option.]]></string>
Is there no way around this inline CDATA stuff? I find it quite likely that
translators will mess this up...

[diegocarloslima, 2017-01-06 14:55:40]

I also do agree that the more we automate the translation process (through
translations.py + Crowdin), the better

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings.xml
File res/values/strings.xml (right):

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings....
res/values/strings.xml:21: <string name="aa_dialog_message"><![CDATA[Annoying
ads are always blocked, while nonintrusive ads are displayed by default. You can
change this setting at any time by configuring the <b>Allow some nonintrusive
ads</b> option.]]></string>
On 2017/01/06 09:31:47, Felix Dahlke wrote:
> Is there no way around this inline CDATA stuff? I find it quite likely that
> translators will mess this up...

The CDATA is just required because by default, the Android string resources
doesn't support the <p> HTML tag. It just supports <b>, <i> and <u>. So there
are two ways we can adjust the string to leave the CDATA out of the way for
translators

The first option is to replace <p> tags by \n and the string will be like this:
    <string name="sbrowser_dialog_message">Before you can use Adblock Plus, you
must update to Samsung Internet Browser 4.0.\n\nTap \"Get update\" to update
Samsung Internet Browser now. After the download is complete, tap \"Open\".
Then, relaunch Adblock Plus to finish the installation.\n\n</string>

The second option is to use <ENTITY> and reference them in the <string> like
this:
    <!ENTITY aa_dialog_message1 "Before you can use Adblock Plus, you must
update to Samsung Internet Browser 4.0.">
    <!ENTITY aa_dialog_message2 "Tap \"Get update\" to update Samsung Internet
Browser now. After the download is complete, tap \"Open\". Then, relaunch
Adblock Plus to finish the installation.">
    <string
name="sbrowser_dialog_message"><![CDATA[<p>&aa_dialog_message1;</p>&aa_dialog_message2;<p></p>]]></string>
We can put complex <string> tags like this one in a separate file and only the
relevant content will be sent to translation

[Felix Dahlke, 2017-01-06 15:05:41]

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings.xml
File res/values/strings.xml (right):

https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings....
res/values/strings.xml:21: <string name="aa_dialog_message"><![CDATA[Annoying
ads are always blocked, while nonintrusive ads are displayed by default. You can
change this setting at any time by configuring the <b>Allow some nonintrusive
ads</b> option.]]></string>
On 2017/01/06 14:55:40, diegocarloslima wrote:
> On 2017/01/06 09:31:47, Felix Dahlke wrote:
> > Is there no way around this inline CDATA stuff? I find it quite likely that
> > translators will mess this up...
> 
> The CDATA is just required because by default, the Android string resources
> doesn't support the <p> HTML tag. It just supports <b>, <i> and <u>. So there
> are two ways we can adjust the string to leave the CDATA out of the way for
> translators
> 
> The first option is to replace <p> tags by \n and the string will be like
this:
>     <string name="sbrowser_dialog_message">Before you can use Adblock Plus,
you
> must update to Samsung Internet Browser 4.0.\n\nTap \"Get update\" to update
> Samsung Internet Browser now. After the download is complete, tap \"Open\".
> Then, relaunch Adblock Plus to finish the installation.\n\n</string>
> 
> The second option is to use <ENTITY> and reference them in the <string> like
> this:
>     <!ENTITY aa_dialog_message1 "Before you can use Adblock Plus, you must
> update to Samsung Internet Browser 4.0.">
>     <!ENTITY aa_dialog_message2 "Tap \"Get update\" to update Samsung Internet
> Browser now. After the download is complete, tap \"Open\". Then, relaunch
> Adblock Plus to finish the installation.">
>     <string
>
name="sbrowser_dialog_message"><![CDATA[<p>&aa_dialog_message1;</p>&aa_dialog_message2;<p></p>]]></string>
> We can put complex <string> tags like this one in a separate file and only the
> relevant content will be sent to translation

No really strong opinion, none of the options seems amazing... I figure we can
stick to CDATA and see how well Crowdin/agencies will handle that.

[anton, 2017-01-09 09:58:45]

On 2017/01/04 17:27:41, diegocarloslima wrote:

LGTM