libadblockplus-android-settings/AndroidManifest.xml - Issue 29371750: Issue 4794 - adblock engine creating/releasing concurrency

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: libadblockplus-android-settings/AndroidManifest.xml

Issue 29371750: Issue 4794 - adblock engine creating/releasing concurrency (Closed)

Patch Set: Created Jan. 13, 2017, 11:44 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"	2 <manifest xmlns:android="http://schemas.android.com/apk/res/android"

3 package="org.adblockplus.libadblockplus.android.settings"	3 package="org.adblockplus.libadblockplus.android.settings"

4 » android:versionCode="1"	4 » android:versionCode="2"

5 » android:versionName="1.0" >	5 » android:versionName="1.1" >
	diegocarloslima 2017/01/25 11:38:19 I would go for versionName "1.0.1". Since it's a s I would go for versionName "1.0.1". Since it's a small fix, it makes more sense to call it a patch than a minor update anton 2017/01/25 11:51:58 Acknowledged. Show quoted text On 2017/01/25 11:38:19, diegocarloslima wrote: > I would go for versionName "1.0.1". Since it's a small fix, it makes more sense > to call it a patch than a minor update Acknowledged.
6	6

7 <uses-sdk	7 <uses-sdk

8 android:minSdkVersion="21"	8 android:minSdkVersion="21"

9 android:targetSdkVersion="21" />	9 android:targetSdkVersion="21" />

10	10

11 </manifest>	11 </manifest>

OLD	NEW