Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29371750: Issue 4794 - adblock engine creating/releasing concurrency (Closed)

Created:
Jan. 13, 2017, 11:44 a.m. by anton
Modified:
March 13, 2017, 5:27 a.m.
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 4794 - adblock engine creating/releasing concurrency

Patch Set 1 #

Total comments: 8

Patch Set 2 : updated versions (from minor to patches), made gradle/maven versions consistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M libadblockplus-android-settings/AndroidManifest.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android-settings/build.gradle View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android-settings/pom.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java View 6 chunks +21 lines, -13 lines 0 comments Download
M libadblockplus-android-webview/pom.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download
M libadblockplus-android-webviewapp/AndroidManifest.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android-webviewapp/build.gradle View 1 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus-android-webviewapp/pom.xml View 1 3 chunks +3 lines, -3 lines 0 comments Download
M libadblockplus-android/pom.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M pom.xml View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
anton
https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-webviewapp/AndroidManifest.xml File libadblockplus-android-webviewapp/AndroidManifest.xml (right): https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-webviewapp/AndroidManifest.xml#newcode5 libadblockplus-android-webviewapp/AndroidManifest.xml:5: android:versionName="1.1"> updated it since -settings version was increased as ...
Jan. 13, 2017, 11:47 a.m. (2017-01-13 11:47:55 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml File libadblockplus-android-settings/AndroidManifest.xml (right): https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml#newcode5 libadblockplus-android-settings/AndroidManifest.xml:5: android:versionName="1.1" > I would go for versionName "1.0.1". Since ...
Jan. 25, 2017, 11:38 a.m. (2017-01-25 11:38:19 UTC) #2
anton
https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml File libadblockplus-android-settings/AndroidManifest.xml (right): https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml#newcode5 libadblockplus-android-settings/AndroidManifest.xml:5: android:versionName="1.1" > On 2017/01/25 11:38:19, diegocarloslima wrote: > I ...
Jan. 25, 2017, 11:51 a.m. (2017-01-25 11:51:59 UTC) #3
diegocarloslima
On 2017/01/25 11:51:59, anton wrote: > https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml > File libadblockplus-android-settings/AndroidManifest.xml (right): > > https://codereview.adblockplus.org/29371750/diff/29371751/libadblockplus-android-settings/AndroidManifest.xml#newcode5 > ...
Feb. 3, 2017, 5:59 p.m. (2017-02-03 17:59:28 UTC) #4
René Jeschke
March 9, 2017, 11:05 a.m. (2017-03-09 11:05:42 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld