Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29372656: NoIssue - Fix group name regex failed (Closed)

Created:
Jan. 18, 2017, 4:33 p.m. by f.lopez
Modified:
Jan. 23, 2017, 2:42 p.m.
Reviewers:
mathias
CC:
f.nicolaisen_adblockplus.org, Fred
Visibility:
Public.

Description

NoIssue - Fix group name regex failed

Patch Set 1 #

Patch Set 2 : NoIssue - Fix failed regex for nginx group name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/notificationserver/templates/global.conf.erb View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
f.lopez
Jan. 18, 2017, 4:33 p.m. (2017-01-18 16:33:29 UTC) #1
mathias
LGTM. A better commit message than the title here maybe?
Jan. 18, 2017, 4:58 p.m. (2017-01-18 16:58:47 UTC) #2
mathias
On 2017/01/18 16:58:47, mathias wrote: > LGTM. A better commit message than the title here ...
Jan. 18, 2017, 5:01 p.m. (2017-01-18 17:01:56 UTC) #3
f.lopez
On 2017/01/18 16:58:47, mathias wrote: > LGTM. A better commit message than the title here ...
Jan. 18, 2017, 5:02 p.m. (2017-01-18 17:02:07 UTC) #4
f.lopez
Jan. 18, 2017, 5:52 p.m. (2017-01-18 17:52:07 UTC) #5
mathias
Jan. 18, 2017, 5:52 p.m. (2017-01-18 17:52:30 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld