Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29372751: Issue4818: Replaced "Eyeo" with "eyeo" for branding consistancy (Closed)

Created:
Jan. 20, 2017, 2:50 a.m. by Lisa
Modified:
Feb. 1, 2017, 4:25 p.m.
CC:
ben
Visibility:
Public.

Description

Issue4818: Replaced "Eyeo" with "eyeo" for branding consistancy

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 4818 - Changed "Eyeo" to "eyeo" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -83 lines) Patch
M includes/contact/address.md View 2 chunks +2 lines, -2 lines 0 comments Download
M includes/index/whoweare.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/jobs/header.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M includes/jobs/overview.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/jobs/why.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/press/company-info.md View 1 chunk +3 lines, -3 lines 0 comments Download
M includes/press/facts.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/press/faq.md View 1 chunk +6 lines, -6 lines 0 comments Download
M includes/press/media.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/press/overview.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/services/overview.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/services/publisher.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/jobs/frontend-developer.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/jobs/social-media-manager.md View 1 chunk +7 lines, -7 lines 0 comments Download
M pages/jobs/speculative-application.md View 3 chunks +4 lines, -4 lines 0 comments Download
M pages/jobs/student-help.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/jobs/whitelist-maintainer.md View 1 chunk +3 lines, -3 lines 0 comments Download
M static/acceptable-ads-application.html View 10 chunks +31 lines, -31 lines 0 comments Download
M static/pad/abp_android_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abp_chrome_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abp_firefox_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abp_ie_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abp_opera_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abp_safari_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/abpchrome_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/urlfixer_firefox_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M static/pad/urlfixer_pad.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M templates/default.tmpl View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Lisa
Jan. 20, 2017, 2:50 a.m. (2017-01-20 02:50:58 UTC) #1
saroyanm
Found some more Eyeo texts: https://hg.adblockplus.org/web.eyeo.com/file/tip/includes/press/releases.tmpl#l15 https://hg.adblockplus.org/web.eyeo.com/file/tip/pages/jobs/index.tmpl#l1 And also inside of XML documents: https://hg.adblockplus.org/web.eyeo.com/file/tip/static/pad Not ...
Jan. 23, 2017, 2:47 p.m. (2017-01-23 14:47:58 UTC) #2
Lisa
@Manvel: Changed "Eyeo" to "eyeo" in additional files you mentioned. I did not change the ...
Jan. 24, 2017, 2:29 p.m. (2017-01-24 14:29:19 UTC) #3
Lisa
Jan. 24, 2017, 2:42 p.m. (2017-01-24 14:42:01 UTC) #4
saroyanm
Feb. 1, 2017, 2:29 p.m. (2017-02-01 14:29:21 UTC) #5 
LGTM 

Please also use commit message using the pattern described in Getting started
guide, so the ticket will be updated with the commit message automatically:
https://docs.google.com/document/d/1WnXJQDYwUBPdzLsQEZEi_nuYaibrtkR8ovuKIaG14...

Pattern: Issue {issue-number} - {commit msg}
So the the commit message in this case should be, something like:

"Issue 4818 - Replaced 'Eyeo' with 'eyeo' and fixed ABP support text"

Powered by Google App Engine
This is Rietveld