Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375712: Noissue - Use of hiera variables for total processes warning and critical values (Closed)

Created:
Feb. 14, 2017, 7:58 p.m. by f.lopez
Modified:
Feb. 15, 2017, 4:10 p.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

Noissue - Use of hiera variables for total processes warning and critical values

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M modules/nagios/templates/nrpe.cfg.erb View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
f.lopez
Feb. 14, 2017, 7:58 p.m. (2017-02-14 19:58:13 UTC) #1
mathias
https://codereview.adblockplus.org/29375712/diff/29375713/modules/nagios/templates/nrpe.cfg.erb File modules/nagios/templates/nrpe.cfg.erb (right): https://codereview.adblockplus.org/29375712/diff/29375713/modules/nagios/templates/nrpe.cfg.erb#newcode15 modules/nagios/templates/nrpe.cfg.erb:15: scope.function_hiera(['nagios::client::total_procs_warning_threshold', 150]).to_i %> -c <%=scope.function_hiera(['nagios::client::total_procs_critical_threshold', 200]).to_i %> Newlines before ...
Feb. 14, 2017, 8:18 p.m. (2017-02-14 20:18:29 UTC) #2
f.lopez
Feb. 14, 2017, 8:54 p.m. (2017-02-14 20:54:32 UTC) #3
mathias
Feb. 14, 2017, 9:40 p.m. (2017-02-14 21:40:04 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld