Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29375888: [adblockpluscore] Issue 4911 - Merge ElemHideEmulation.load/apply into one function (Closed)

Created:
Feb. 18, 2017, 11:08 a.m. by wspee
Modified:
Feb. 23, 2017, 10:31 a.m.
Visibility:
Public.

Description

[adblockpluscore] Issue 4911 - Merge ElemHideEmulation.load/apply into one function See https://codereview.adblockplus.org/29370970/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unused callback parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/content/elemHideEmulation.js View 1 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 5
wspee
Feb. 18, 2017, 11:20 a.m. (2017-02-18 11:20:58 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29375888/diff/29375889/chrome/content/elemHideEmulation.js File chrome/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29375888/diff/29375889/chrome/content/elemHideEmulation.js#newcode124 chrome/content/elemHideEmulation.js:124: apply: function(callback) The callback parameter is unused now.
Feb. 18, 2017, 11:28 a.m. (2017-02-18 11:28:13 UTC) #2
wspee
https://codereview.adblockplus.org/29375888/diff/29375889/chrome/content/elemHideEmulation.js File chrome/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29375888/diff/29375889/chrome/content/elemHideEmulation.js#newcode124 chrome/content/elemHideEmulation.js:124: apply: function(callback) On 2017/02/18 11:28:13, Sebastian Noack wrote: > ...
Feb. 18, 2017, 12:49 p.m. (2017-02-18 12:49:50 UTC) #3
Sebastian Noack
LGTM
Feb. 18, 2017, 1 p.m. (2017-02-18 13:00:31 UTC) #4
Wladimir Palant
Feb. 21, 2017, 10:22 a.m. (2017-02-21 10:22:24 UTC) #5
LGTM

Good to have this simplified.

Powered by Google App Engine
This is Rietveld