Issue 4950 - Add -fpermissive to allow building on recent gcc.This is caused by V8 code.Possibly…

Issue 4950 - Add -fpermissive to allow building on recent gcc.

This is caused by V8 code.
Possibly revert this when we have a newer version of V8

[Felix Dahlke, 2017-03-06 17:00:42]

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi
File common.gypi (right):

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi#newcode17
common.gypi:17: '-pedantic', '-std=c++0x', '-fexceptions', '-fpermissive' ],
I'm a bit rusty with this build logic, but:

1. Is GCC only possible to use on the systems listed above? Not on macOS? AKA:
Is this the only place where we need to add the flag?
2. Can we do comments in this file (I know it's JSON...)? We should point out
that we want to get rid of `-fpermissive` after the V8 upgrade.

[hub, 2017-03-06 17:41:41]

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi
File common.gypi (right):

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi#newcode17
common.gypi:17: '-pedantic', '-std=c++0x', '-fexceptions', '-fpermissive' ],
On 2017/03/06 17:00:41, Felix Dahlke wrote:
> I'm a bit rusty with this build logic, but:
> 
> 1. Is GCC only possible to use on the systems listed above? Not on macOS? AKA:
> Is this the only place where we need to add the flag?
> 2. Can we do comments in this file (I know it's JSON...)? We should point out
> that we want to get rid of `-fpermissive` after the V8 upgrade.

There is no GCC with C++11 support in macOS (they stop at a badly patched 4.2.1,
because 4.2.2 changed licensing), unless you manually install it (ith Homebrew
for example). Below, the settings are for clang which is what it will default
too. Note: the BSD have moved to clang recently I think, but clang accepts
-fpermissive too.

We can do comments in the .gypi file:
https://gyp.gsrc.io/docs/InputFormatReference.md#Comments

So if you want, I can add the comment.

[Felix Dahlke, 2017-03-07 07:30:00]

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi
File common.gypi (right):

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi#newcode17
common.gypi:17: '-pedantic', '-std=c++0x', '-fexceptions', '-fpermissive' ],
On 2017/03/06 17:41:41, hub wrote:
> On 2017/03/06 17:00:41, Felix Dahlke wrote:
> > I'm a bit rusty with this build logic, but:
> > 
> > 1. Is GCC only possible to use on the systems listed above? Not on macOS?
AKA:
> > Is this the only place where we need to add the flag?
> > 2. Can we do comments in this file (I know it's JSON...)? We should point
out
> > that we want to get rid of `-fpermissive` after the V8 upgrade.
> 
> There is no GCC with C++11 support in macOS (they stop at a badly patched
4.2.1,
> because 4.2.2 changed licensing), unless you manually install it (ith Homebrew
> for example). Below, the settings are for clang which is what it will default
> too. Note: the BSD have moved to clang recently I think, but clang accepts
> -fpermissive too.

I just checked and when I build on my Ubuntu system it actually uses Clang. I
couldn't figure out how to force the build to use GCC instead so I couldn't
reproduce this issue.

I'm not entirely happy with adding `-fpermissive` on an OS basis
(linux/freebsd/openbsd/solaris/netbsd/android) when it is actually needed just
for GCC (regardless of the system). Could you look into whether we could only
set this when GCC is used? If that's not possible this is alright by me though.

> We can do comments in the .gypi file:
> https://gyp.gsrc.io/docs/InputFormatReference.md#Comments
> 
> So if you want, I can add the comment.

Yes please add one, referring to issue 4950.

[hub, 2017-03-07 16:36:18]

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi
File common.gypi (right):

https://codereview.adblockplus.org/29377871/diff/29377872/common.gypi#newcode17
common.gypi:17: '-pedantic', '-std=c++0x', '-fexceptions', '-fpermissive' ],
On 2017/03/07 07:29:59, Felix Dahlke wrote:

> I just checked and when I build on my Ubuntu system it actually uses Clang. I
> couldn't figure out how to force the build to use GCC instead so I couldn't
> reproduce this issue.
> 
> I'm not entirely happy with adding `-fpermissive` on an OS basis
> (linux/freebsd/openbsd/solaris/netbsd/android) when it is actually needed just
> for GCC (regardless of the system). Could you look into whether we could only
> set this when GCC is used? If that's not possible this is alright by me
though.

I haven't figured out how to do that with gyp. There don't seem to be any way to
select based on the compiler. :-/

[Felix Dahlke, 2017-03-07 16:40:42]

LGTM