Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: common.gypi

Issue 29377871: Issue 4950 - Add -fpermissive to allow building on recent gcc.This is caused by V8 code.Possibly… (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: update comment Created March 7, 2017, 4:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common.gypi
===================================================================
--- a/common.gypi
+++ b/common.gypi
@@ -7,19 +7,23 @@
'v8_optimized_debug': 0,
'v8_enable_i18n_support': 0,
},
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
or OS=="netbsd" or OS=="android"', {
'target_defaults': {
+ # V8 headers cause a build error on recent gcc.
+ # Adding -fpermissive to solve this.
+ # See https://issues.adblockplus.org/ticket/4950
+ # We might be able to do without after upgrading V8.
'cflags': [ '-Wall', '-W', '-Wno-unused-parameter',
'-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
- '-pedantic', '-std=c++0x', '-fexceptions', ],
+ '-pedantic', '-std=c++0x', '-fexceptions', '-fpermissive' ],
'cflags!': [ '-Werror', ],
'ldflags': [ '-pthread', ],
},
}],
['OS=="mac"', {
'xcode_settings': {
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
'CLANG_CXX_LIBRARY': 'libc++',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld