Issue 4998 - Add .gitignore

Issue 4998 - Add .gitignore

[Felix Dahlke, 2017-03-16 10:49:18]

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore
File .gitignore (left):

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore#oldcode1
.gitignore:1: syntax: glob
Isn't that the default behaviour in Git? Does it even support this syntax
directive?

[anton, 2017-03-16 11:06:43]

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore
File .gitignore (left):

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore#oldcode1
.gitignore:1: syntax: glob
On 2017/03/16 10:49:18, Felix Dahlke wrote:
> Isn't that the default behaviour in Git? Does it even support this syntax
> directive?

The file was created by just copy/renaming from .hgignore.
It's Git default behaviour so we don't need it (and yes - Git does not support
`syntax` - https://git-scm.com/docs/gitignore).
BTW - same here
https://codereview.adblockplus.org/29384850/diff/29384851/.gitignore

[Felix Dahlke, 2017-03-16 11:08:36]

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore
File .gitignore (left):

https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore#oldcode1
.gitignore:1: syntax: glob
On 2017/03/16 11:06:43, anton wrote:
> On 2017/03/16 10:49:18, Felix Dahlke wrote:
> > Isn't that the default behaviour in Git? Does it even support this syntax
> > directive?
> 
> The file was created by just copy/renaming from .hgignore.
> It's Git default behaviour so we don't need it (and yes - Git does not support
> `syntax` - https://git-scm.com/docs/gitignore).
> BTW - same here
> https://codereview.adblockplus.org/29384850/diff/29384851/.gitignore

I'd still say let's leave it out (didn't catch it in that other review). (See
the .gitignore files in our other repos such as adblockplus and
adblockpluschrome)

[anton, 2017-03-16 11:11:43]

On 2017/03/16 11:08:36, Felix Dahlke wrote:
> https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore
> File .gitignore (left):
> 
> https://codereview.adblockplus.org/29385633/diff/29385634/.gitignore#oldcode1
> .gitignore:1: syntax: glob
> On 2017/03/16 11:06:43, anton wrote:
> > On 2017/03/16 10:49:18, Felix Dahlke wrote:
> > > Isn't that the default behaviour in Git? Does it even support this syntax
> > > directive?
> > 
> > The file was created by just copy/renaming from .hgignore.
> > It's Git default behaviour so we don't need it (and yes - Git does not
support
> > `syntax` - https://git-scm.com/docs/gitignore).
> > BTW - same here
> > https://codereview.adblockplus.org/29384850/diff/29384851/.gitignore
> 
> I'd still say let's leave it out (didn't catch it in that other review). (See
> the .gitignore files in our other repos such as adblockplus and
> adblockpluschrome)

see patch set #2

[Felix Dahlke, 2017-03-16 11:36:25]

LGTM

[diegocarloslima, 2017-03-16 19:28:45]

On 2017/03/16 11:36:25, Felix Dahlke wrote:
> LGTM

LGTM