Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29385757: Issue 5005 - Always show the menu icon (Closed)

Created:
March 16, 2017, 9:58 p.m. by diegocarloslima
Modified:
June 1, 2017, 9:58 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5005 - Always show the menu icon

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M mobile/android/base/util/HardwareUtils.java View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
diegocarloslima
March 16, 2017, 10:09 p.m. (2017-03-16 22:09:11 UTC) #1
anton
https://codereview.adblockplus.org/29385757/diff/29385758/mobile/android/base/util/HardwareUtils.java File mobile/android/base/util/HardwareUtils.java (right): https://codereview.adblockplus.org/29385757/diff/29385758/mobile/android/base/util/HardwareUtils.java#newcode93 mobile/android/base/util/HardwareUtils.java:93: // Forcing behavior idependently of the presence of a ...
March 17, 2017, 6:53 a.m. (2017-03-17 06:53:11 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29385757/diff/29385758/mobile/android/base/util/HardwareUtils.java File mobile/android/base/util/HardwareUtils.java (right): https://codereview.adblockplus.org/29385757/diff/29385758/mobile/android/base/util/HardwareUtils.java#newcode93 mobile/android/base/util/HardwareUtils.java:93: // Forcing behavior idependently of the presence of a ...
March 27, 2017, 3:46 p.m. (2017-03-27 15:46:57 UTC) #3
Felix Dahlke
May 9, 2017, 8 a.m. (2017-05-09 08:00:03 UTC) #4
Woops, forgot about this. LGTM.

Powered by Google App Engine
This is Rietveld