Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29393573: Issue 4692 - Dont' keep a strong reference from timer thread (Closed)

Created:
March 23, 2017, 5:19 p.m. by sergei
Modified:
March 24, 2017, 1:59 p.m.
Reviewers:
Eric, Oleksandr, hub
CC:
Felix Dahlke, anton
Visibility:
Public.

Patch Set 1 #

Total comments: 7

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -23 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 3 chunks +17 lines, -0 lines 0 comments Download
M src/GlobalJsObject.cpp View 1 2 chunks +8 lines, -23 lines 0 comments Download
M src/JsEngine.cpp View 1 2 chunks +37 lines, -0 lines 0 comments Download
M test/GlobalJsObject.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
sergei
https://codereview.adblockplus.org/29393573/diff/29393584/include/AdblockPlus/JsEngine.h File include/AdblockPlus/JsEngine.h (right): https://codereview.adblockplus.org/29393573/diff/29393584/include/AdblockPlus/JsEngine.h#newcode278 include/AdblockPlus/JsEngine.h:278: std::vector<std::unique_ptr<v8::Persistent<v8::Value>>> arguments; We need std::unique_ptr here because v8::Persistent from ...
March 23, 2017, 5:27 p.m. (2017-03-23 17:27:13 UTC) #1
Oleksandr
Overall this seems to go in conflict with https://codereview.adblockplus.org/29369365 where this is resolved differently and ...
March 24, 2017, 12:15 p.m. (2017-03-24 12:15:25 UTC) #2
sergei
On 2017/03/24 12:15:25, Oleksandr wrote: > Overall this seems to go in conflict with > ...
March 24, 2017, 12:34 p.m. (2017-03-24 12:34:39 UTC) #3
Oleksandr
March 24, 2017, 1:31 p.m. (2017-03-24 13:31:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld