modules/web/manifests/server.pp - Issue 29396643: NoIssue - Reconfigure Mercurial pull cron-jobs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/web/manifests/server.pp

Issue 29396643: NoIssue - Reconfigure Mercurial pull cron-jobs (Closed)

Left Patch Set: Add a missing cronjob Created March 29, 2017, 12:06 a.m.

Right Patch Set: For comment #4 Created March 29, 2017, 12:13 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 class web::server(	1 class web::server(

2 $vhost,	2 $vhost,

3 $repository,	3 $repository,

4 $certificate = hiera('web::server::certificate', 'undef'),	4 $certificate = hiera('web::server::certificate', 'undef'),

5 $private_key = hiera('web::server::private_key', 'undef'),	5 $private_key = hiera('web::server::private_key', 'undef'),

6 $is_default = false,	6 $is_default = false,

7 $aliases = undef,	7 $aliases = undef,

8 $custom_config = undef,	8 $custom_config = undef,

9 $multiplexer_locations = undef,	9 $multiplexer_locations = undef,

10 $geoip = false,	10 $geoip = false,

(...skipping 114 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
125 "/var/www/docs",	125 "/var/www/docs",

126 ]:	126 ]:

127 ensure => directory,	127 ensure => directory,

128 owner => www,	128 owner => www,

129 mode => 755,	129 mode => 755,

130 }	130 }

131	131

132 cron {'update_cms':	132 cron {'update_cms':

133 ensure => present,	133 ensure => present,

134 command => "hg pull -q -u -R /opt/cms",	134 command => "hg pull -q -u -R /opt/cms",

135 minute => '5-55/20',	135 minute => '4-59/20',
mathias 2017/03/29 00:10:55 Why -55 when all similar ones use -59? Why -55 when all similar ones use -59?
136 }	136 }

137	137

138 cron {'update_repo':	138 cron {'update_repo':

139 ensure => present,	139 ensure => present,

140 command => "hg pull -q -R /home/www/${repository} && python -m cms.bin.gener ate_static_pages /home/www/${repository} /var/www/${vhost}",	140 command => "hg pull -q -R /home/www/${repository} && python -m cms.bin.gener ate_static_pages /home/www/${repository} /var/www/${vhost}",

141 user => www,	141 user => www,

142 minute => '4-59/20',	142 minute => '5-59/20',
mathias 2017/03/29 00:10:55 This should probably happen in the minute after up This should probably happen in the minute after update_cms, not before.
143 }	143 }

144	144

145 }	145 }

LEFT	RIGHT