Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29396643: NoIssue - Reconfigure Mercurial pull cron-jobs (Closed)

Created:
March 28, 2017, 7:36 p.m. by f.lopez
Modified:
March 29, 2017, 12:39 a.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

NoIssue - Reconfigure Mercurial pull cron-jobs

Patch Set 1 #

Patch Set 2 : Add a missing cronjob #

Total comments: 2

Patch Set 3 : For comment #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M manifests/webserver.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/downloadserver/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/notificationserver/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/sitescripts/manifests/init.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/web/manifests/server.pp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
f.lopez
March 28, 2017, 7:36 p.m. (2017-03-28 19:36:55 UTC) #1
mathias
LGTM.
March 28, 2017, 8:04 p.m. (2017-03-28 20:04:07 UTC) #2
f.lopez
March 29, 2017, 12:06 a.m. (2017-03-29 00:06:22 UTC) #3
mathias
https://codereview.adblockplus.org/29396643/diff/29396665/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29396643/diff/29396665/modules/web/manifests/server.pp#newcode135 modules/web/manifests/server.pp:135: minute => '5-55/20', Why -55 when all similar ones ...
March 29, 2017, 12:10 a.m. (2017-03-29 00:10:55 UTC) #4
f.lopez
March 29, 2017, 12:13 a.m. (2017-03-29 00:13:28 UTC) #5
mathias
March 29, 2017, 12:14 a.m. (2017-03-29 00:14:36 UTC) #6
LGTM.

Powered by Google App Engine
This is Rietveld