Issue 3768 - Check (and fix, if needed) multilocale builds

Issue 3768 - Check (and fix, if needed) multilocale builds

Sibling of https://codereview.adblockplus.org/29374901/

[Felix Dahlke, 2017-03-31 09:53:54]

Looks good, just one nit.

https://codereview.adblockplus.org/29399743/diff/29399744/build.py
File build.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/build.py#newcode156
build.py:156: "architecture", "architectures", _ARCHS)
Seems unrelated, could you do this in a separate noissue commit?

[diegocarloslima, 2017-03-31 10:07:23]

https://codereview.adblockplus.org/29399743/diff/29399744/build.py
File build.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/build.py#newcode156
build.py:156: "architecture", "architectures", _ARCHS)
On 2017/03/31 09:53:54, Felix Dahlke wrote:
> Seems unrelated, could you do this in a separate noissue commit?

Acknowledged.

[anton, 2017-04-03 06:28:11]

https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg.py
File adblockbrowser-cfg.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg....
adblockbrowser-cfg.py:29: "ignore_locales": ["en-US", "en-ZA", "multi"],
why "en-ZA" is ignored?

https://codereview.adblockplus.org/29399743/diff/29399744/build.py
File build.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/build.py#newcode54
build.py:54: os.makedirs(_GENERATED_PATH)
i had to figure this out when trying to build it about a week ago from scratch
;)
Not sure it's in the scope of this task, but it's definitely required change.

https://codereview.adblockplus.org/29399743/diff/29399744/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399743/diff/29399744/dependencies#newcode3
dependencies:3: adblockbrowser = adblockbrowser hg:257ce97008ad
just a question: why don't we have it on Github?

https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies.py
File ensure_dependencies.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies...
ensure_dependencies.py:2: # coding: utf-8
it seems to be not the latest revision body for 'ensure_dependencies.py' from
'buildtools':
https://github.com/adblockplus/buildtools/blob/master/ensure_dependencies.py#L2

why that?

[diegocarloslima, 2017-04-03 09:57:09]

https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg.py
File adblockbrowser-cfg.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg....
adblockbrowser-cfg.py:29: "ignore_locales": ["en-US", "en-ZA", "multi"],
On 2017/04/03 06:28:11, anton wrote:
> why "en-ZA" is ignored?

en-ZA is missing the FENNEC_44_0_2_RELEASE tag, so it fails to checkout. It
seems that the Android strings were added just from version 48 and on for this
locale. For the next merge, I believe we'll be able to remove this ignore

https://codereview.adblockplus.org/29399743/diff/29399744/dependencies
File dependencies (right):

https://codereview.adblockplus.org/29399743/diff/29399744/dependencies#newcode3
dependencies:3: adblockbrowser = adblockbrowser hg:257ce97008ad
On 2017/04/03 06:28:11, anton wrote:
> just a question: why don't we have it on Github?

Because ABB repo is over 1GB, which kinda exceeds GitHub storage limit. Also, it
seems that Git performs quite slower if compared to Mercurial for a huge
repository like this

https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies.py
File ensure_dependencies.py (right):

https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies...
ensure_dependencies.py:2: # coding: utf-8
On 2017/04/03 06:28:11, anton wrote:
> it seems to be not the latest revision body for 'ensure_dependencies.py' from
> 'buildtools':
>
https://github.com/adblockplus/buildtools/blob/master/ensure_dependencies.py#L2
> 
> why that?

It uses the revision stored in adblockbrowser to update. From the dependencies
file:
_self = adblockbrowser/adblockplus/adblockplus/buildtools/ensure_dependencies.py

[anton, 2017-04-03 10:18:47]

On 2017/04/03 09:57:09, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg.py
> File adblockbrowser-cfg.py (right):
> 
>
https://codereview.adblockplus.org/29399743/diff/29399744/adblockbrowser-cfg....
> adblockbrowser-cfg.py:29: "ignore_locales": ["en-US", "en-ZA", "multi"],
> On 2017/04/03 06:28:11, anton wrote:
> > why "en-ZA" is ignored?
> 
> en-ZA is missing the FENNEC_44_0_2_RELEASE tag, so it fails to checkout. It
> seems that the Android strings were added just from version 48 and on for this
> locale. For the next merge, I believe we'll be able to remove this ignore
> 
> https://codereview.adblockplus.org/29399743/diff/29399744/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29399743/diff/29399744/dependencies#newcode3
> dependencies:3: adblockbrowser = adblockbrowser hg:257ce97008ad
> On 2017/04/03 06:28:11, anton wrote:
> > just a question: why don't we have it on Github?
> 
> Because ABB repo is over 1GB, which kinda exceeds GitHub storage limit. Also,
it
> seems that Git performs quite slower if compared to Mercurial for a huge
> repository like this
> 
>
https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies.py
> File ensure_dependencies.py (right):
> 
>
https://codereview.adblockplus.org/29399743/diff/29399744/ensure_dependencies...
> ensure_dependencies.py:2: # coding: utf-8
> On 2017/04/03 06:28:11, anton wrote:
> > it seems to be not the latest revision body for 'ensure_dependencies.py'
from
> > 'buildtools':
> >
>
https://github.com/adblockplus/buildtools/blob/master/ensure_dependencies.py#L2
> > 
> > why that?
> 
> It uses the revision stored in adblockbrowser to update. From the dependencies
> file:
> _self =
adblockbrowser/adblockplus/adblockplus/buildtools/ensure_dependencies.py

LGTM though it's unclear why not to put changes into
buildtools/ensure_dependencies.py and then just use it.

[Felix Dahlke, 2017-04-03 16:26:36]

LGTM

On 2017/04/03 10:18:47, anton wrote:
> LGTM though it's unclear why not to put changes into
> buildtools/ensure_dependencies.py and then just use it.

You mean the ensure_dependencies.py changes? Those weren't actually made by
Diego, the script is copied to each repo and automatically updated whenever the
buildtools dependency gets updated.

[anton, 2017-04-04 05:09:50]

On 2017/04/03 16:26:36, Felix Dahlke wrote:
> LGTM
> 
> On 2017/04/03 10:18:47, anton wrote:
> > LGTM though it's unclear why not to put changes into
> > buildtools/ensure_dependencies.py and then just use it.
> 
> You mean the ensure_dependencies.py changes? Those weren't actually made by
> Diego, the script is copied to each repo and automatically updated whenever
the
> buildtools dependency gets updated.

Yes, i know but it's copied after the 1st run. But current
ensure_dependencies.py isn't equal to the last version from buildtools repo and
this is misleading.

[Felix Dahlke, 2017-04-04 08:04:46]

On 2017/04/04 05:09:50, anton wrote:
> On 2017/04/03 16:26:36, Felix Dahlke wrote:
> > LGTM
> > 
> > On 2017/04/03 10:18:47, anton wrote:
> > > LGTM though it's unclear why not to put changes into
> > > buildtools/ensure_dependencies.py and then just use it.
> > 
> > You mean the ensure_dependencies.py changes? Those weren't actually made by
> > Diego, the script is copied to each repo and automatically updated whenever
> the
> > buildtools dependency gets updated.
> 
> Yes, i know but it's copied after the 1st run. But current
> ensure_dependencies.py isn't equal to the last version from buildtools repo
and
> this is misleading.

It is how I see it identical to revision 3816c08c0f98 of buildtools, which is
what the adblockbrowser->adblockplus->buildtools dependency chain refers to. If
we update adblockbrowser-build to point to an adblockbrowser revision that uses
an adblockplus revision that uses the latest revision of buildtools, the latest
version will get copied.