Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29399777: Issue 4976 - remove language selector AND noissue - fix sidebar offset (Closed)

Created:
March 31, 2017, 3:11 p.m. by juliandoucette
Modified:
April 3, 2017, 6:21 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 4976 - remove language selector AND noissue - fix sidebar offset

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M includes/sidebar/secondary-navigation.tmpl View 1 chunk +0 lines, -12 lines 1 comment Download
M templates/default.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
juliandoucette
March 31, 2017, 3:11 p.m. (2017-03-31 15:11:38 UTC) #1
saroyanm
LGTM with one comment. https://codereview.adblockplus.org/29399777/diff/29399778/includes/sidebar/secondary-navigation.tmpl File includes/sidebar/secondary-navigation.tmpl (left): https://codereview.adblockplus.org/29399777/diff/29399778/includes/sidebar/secondary-navigation.tmpl#oldcode28 includes/sidebar/secondary-navigation.tmpl:28: <select id="language-select" name="lang"> We can ...
March 31, 2017, 3:16 p.m. (2017-03-31 15:16:28 UTC) #2
juliandoucette
On 2017/03/31 15:16:28, saroyanm wrote: > LGTM with one comment. > > https://codereview.adblockplus.org/29399777/diff/29399778/includes/sidebar/secondary-navigation.tmpl > File ...
March 31, 2017, 3:17 p.m. (2017-03-31 15:17:25 UTC) #3
juliandoucette
April 3, 2017, 6:21 p.m. (2017-04-03 18:21:19 UTC) #4

Powered by Google App Engine
This is Rietveld